feat: remove redundant app code-base from 2 test-cases #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bidon15
added
enhancement
vgonkivs
reviewed
Aug 30, 2022
vgonkivs
approved these changes
Aug 30, 2022
Wondertan
reviewed
Sep 1, 2022
Move the creation of a validator to the common dir Adjusted the init-validator case to accept the pers-peers param Move home path to app struct to eliminate passing home var to all methods
Co-authored-by: Viacheslav Gonkivskyi <[email protected]>
- eliminate entire go func after testing - move chainId to New func Co-authored-by: Hlib Kanunnikov <[email protected]>
Wondertan
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the creation of a validator to the common dir
Adjusted the init-validator case to accept the pers-peers param
Move home path to app struct to eliminate passing home var to all methods
This is housekeeping part to start implementing #55
Closes #46