-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add TP#001 for Big Blocks #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. I like the taken documentation approach.
A few comments:
- Syncing and dasing from the network perspective are the same. What for full Nodes is block syncing for light nodes is block dasing. This means that tc-002 == tc-004 and tc-003 == tc-005. So we can keep
-das-
cases only for lights and-sync
only for fulls(right now, both sync and das cases mention Full/Light node types) or combine equal tests into one. - There is a lot of common text between tests that feels too repetitive, but this might be just me, and it might a good thing for such test docs.
docs/test-plans/001-Big-Blocks/tp-001-big-blocks-creation-sync.md
Outdated
Show resolved
Hide resolved
docs/test-plans/001-Big-Blocks/test-cases/tc-003-da-sync-past.md
Outdated
Show resolved
Hide resolved
Thanks for the review! Ok. Then I'll redo cases tc -> 002 004 003 005 to be specific to either Full or Light Yes. The general idea of test-case is to as atomic as possible from a description pov. Having dependencies between tests (both execution and text desc) is a bad design choice |
Co-authored-by: Hlib Kanunnikov <[email protected]>
Co-authored-by: Hlib Kanunnikov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks
Test Plan covers big blocks epic.
Rendered:
Closes #1 #6
Ref: celestiaorg/celestia-node#7 celestiaorg/celestia-node#602