Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(lightclient/groth16): code commitment isn't used or documented #166

Open
rootulp opened this issue Feb 15, 2025 · 1 comment
Open

bug(lightclient/groth16): code commitment isn't used or documented #166

rootulp opened this issue Feb 15, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@rootulp
Copy link
Collaborator

rootulp commented Feb 15, 2025

Context

clientState := groth16.NewClientState(latestBlock.Number().Uint64(), []byte{}, []byte{}, []byte{}, genesisBlock.Root().Bytes())

Problem

CodeCommitment isn't provided in this invocation. Even worse, there are no docs on what code commitment expects.

Proposal

  1. Add a more helpful doc to the CodeCommitment field in client state
  2. Populate a CodeCommitment when creating the Groth16 light client.
@rootulp rootulp added the bug Something isn't working label Feb 15, 2025
@rootulp
Copy link
Collaborator Author

rootulp commented Feb 15, 2025

It may refer to a commitment of the EVM Prover source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant