feat(header): cache hash #3975
Closed
feat(header): cache hash #3975
+35
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
requested review from
renaynay,
Wondertan,
vgonkivs and
walldiss
as code owners
Closed
cristaloleg
commented
Dec 2, 2024
Wondertan
reviewed
Dec 2, 2024
Wondertan
reviewed
Dec 2, 2024
Wondertan
reviewed
Dec 3, 2024
There was a problem hiding this comment.
I carefully reviewed this again and realized that we actually don't need this change.
Here we check that the result of local hashing is equal to what we have in the commit already. So when we return from commit we know its something we computed ourselves. Therefore, we keep returning hash from the commit and there is no need to add recompute value and synchronization around it.
|
Closing as not needed (see Hlib's review comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2959 and Closes #3189