Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shwap): Add validation file #3485

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Conversation

walldiss
Copy link
Member

@walldiss walldiss commented Jun 10, 2024

Adds simple validation middleware to file to prevent unwanted access by invalid index.

@walldiss walldiss added kind:feat Attached to feature PRs shwap labels Jun 10, 2024
@walldiss walldiss self-assigned this Jun 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (shwap@e9fe211). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             shwap    #3485   +/-   ##
========================================
  Coverage         ?   43.49%           
========================================
  Files            ?      290           
  Lines            ?    16649           
  Branches         ?        0           
========================================
  Hits             ?     7242           
  Misses           ?     8569           
  Partials         ?      838           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cristaloleg
Copy link
Contributor

@walldiss walldiss requested a review from cristaloleg as a code owner June 10, 2024 11:54
@walldiss walldiss force-pushed the shwap branch 3 times, most recently from c4550bf to 60e757e Compare June 10, 2024 11:58
Copy link
Contributor

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@Wondertan
Copy link
Member

Linter break?

@Wondertan Wondertan merged commit 958ed80 into celestiaorg:shwap Jun 17, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feat Attached to feature PRs shwap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants