Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Tendermint Telemetry Broken Link #3338

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

Erlangshen219
Copy link
Contributor

@Erlangshen219 Erlangshen219 commented Apr 24, 2024

@github-actions github-actions bot added the external Issues created by non node team members label Apr 24, 2024
Wondertan
Wondertan previously approved these changes Apr 25, 2024
@Wondertan Wondertan changed the title fix: Update Tendermint Telemetry Broken Link chore: Update Tendermint Telemetry Broken Link Apr 25, 2024
@Wondertan Wondertan enabled auto-merge (squash) April 25, 2024 14:59
renaynay
renaynay previously approved these changes Apr 25, 2024
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Erlangshen219 thank you

The cosmos link "https://docs.cosmos.network/main/core/telemetry.html" is also broken, do you mind updating that in the same PR?

auto-merge was automatically disabled April 26, 2024 04:37

Head branch was pushed to by a user without write access

@Erlangshen219 Erlangshen219 dismissed stale reviews from renaynay and Wondertan via f35e3fe April 26, 2024 04:37
@Erlangshen219
Copy link
Contributor Author

@Erlangshen219 thank you

The cosmos link "https://docs.cosmos.network/main/core/telemetry.html" is also broken, do you mind updating that in the same PR?

Yes. Update with this https://docs.cosmos.network/main/learn/advanced/telemetry

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.60%. Comparing base (2469e7a) to head (4b0c4ba).
Report is 42 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3338      +/-   ##
==========================================
- Coverage   44.83%   44.60%   -0.24%     
==========================================
  Files         265      273       +8     
  Lines       14620    15255     +635     
==========================================
+ Hits         6555     6804     +249     
- Misses       7313     7664     +351     
- Partials      752      787      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renaynay renaynay enabled auto-merge (squash) April 30, 2024 17:52
@renaynay renaynay merged commit b6a77a6 into celestiaorg:main Apr 30, 2024
25 checks passed
walldiss pushed a commit to walldiss/celestia-node that referenced this pull request May 7, 2024
Error 404: https://docs.tendermint.com/v0.35/nodes/metrics.html

Fix: https://docs.tendermint.com/main/tendermint-core/metrics.html

<!--
Thank you for submitting a pull request!

Please make sure you have reviewed our contributors guide before
submitting your
first PR.

Error 404: https://docs.tendermint.com/v0.35/nodes/metrics.html

Fix: https://docs.tendermint.com/main/tendermint-core/metrics.html

Please ensure you've addressed or included references to any related
issues.

Tips:
- Use keywords like "closes" or "fixes" followed by an issue number to
automatically close related issues when the PR is merged (e.g., "closes
celestiaorg#123" or "fixes celestiaorg#123").
- Describe the changes made in the PR.
- Ensure the PR has one of the required tags (kind:fix, kind:misc,
kind:break!, kind:refactor, kind:feat, kind:deps, kind:docs, kind:ci,
kind:chore, kind:testing)

-->

---------

Co-authored-by: Hlib Kanunnikov <[email protected]>
(cherry picked from commit b6a77a6)
walldiss pushed a commit to walldiss/celestia-node that referenced this pull request May 7, 2024
Error 404: https://docs.tendermint.com/v0.35/nodes/metrics.html

Fix: https://docs.tendermint.com/main/tendermint-core/metrics.html

<!--
Thank you for submitting a pull request!

Please make sure you have reviewed our contributors guide before
submitting your
first PR.

Error 404: https://docs.tendermint.com/v0.35/nodes/metrics.html

Fix: https://docs.tendermint.com/main/tendermint-core/metrics.html

Please ensure you've addressed or included references to any related
issues.

Tips:
- Use keywords like "closes" or "fixes" followed by an issue number to
automatically close related issues when the PR is merged (e.g., "closes
celestiaorg#123" or "fixes celestiaorg#123").
- Describe the changes made in the PR.
- Ensure the PR has one of the required tags (kind:fix, kind:misc,
kind:break!, kind:refactor, kind:feat, kind:deps, kind:docs, kind:ci,
kind:chore, kind:testing)

-->

---------

Co-authored-by: Hlib Kanunnikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members kind:chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants