bug: Proofs are serialized as strings - undocumented API break in 0.13.0

[zvolin]

Celestia Node version

0.13.0

OS

archlinux

Install tools

No response

Others

No response

Steps to reproduce it

In #3146 change, the Proof serialization changed from a list of proof objects to the list of stringified objects. This is a breaking change for the RPC clients. Is this new behavior expected and should clients like rust celestia-rpc align to it?

My 2 cents is that previous API is cleaner, the string serialization seems rather unnecessary

Expected result

.

Actual result

.

Relevant log output

No response

Notes

No response

[zvolin]

You can see the difference in
https://node-rpc-docs.celestia.org/?version=v0.12.4#blob.GetProof
and
https://node-rpc-docs.celestia.org/?version=v0.13.0#blob.GetProof

[zvolin]

I've just noticed that this also is inconsistent with other rpc methods, like GetSharesByNamespace which will still return the old proof representation (json object)

[ramin]

@zvolin yes i don't think this was intentional, let me chase and discuss with team and i think we'll have to change

[ramin]

@renaynay here is the culprit 625cdf3#diff-e0265c8a8ef591c5dac3ccd849803c7c79932ed3b87bff256fdf9f291611ace4R38

i believe we just need to remove this custom Marshall/Unmarshal and we'll be back to original behavior

[renaynay]

@zvolin does #3204 revert proof marshalling to how it was done previously?

[zvolin]

yup, all our tests passes on that

[renaynay]

Perfect