Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename das module to sampler, or figure out naming for da module #3156

Open
distractedm1nd opened this issue Feb 1, 2024 · 1 comment
Open

fix: rename das module to sampler, or figure out naming for da module #3156

distractedm1nd opened this issue Feb 1, 2024 · 1 comment
Assignees
@distractedm1nd
Labels
area:node Node kind:refactor Attached to refactoring PRs

Comments

@distractedm1nd
Copy link
Collaborator

Context:

          I am OK with calling this da if we change `das` to `sampler` or smlr. Changing, this shouldn't be part of this PR, but we should at least have an issue to clean this ambiguity after this is merged

Originally posted by @Wondertan in #3146 (comment)
@distractedm1nd distractedm1nd added area:node Node kind:fix Attached to bug-fixing PRs labels Feb 1, 2024
@distractedm1nd distractedm1nd self-assigned this Feb 1, 2024
@ramin
Copy link
Contributor

ramin commented Feb 8, 2024

i like renaming das -> sampler personally

@renaynay renaynay added kind:refactor Attached to refactoring PRs and removed kind:fix Attached to bug-fixing PRs needs:triage labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@distractedm1nd distractedm1nd

Labels
area:node Node kind:refactor Attached to refactoring PRs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ramin @distractedm1nd @renaynay