bitswap: BNs + LNs seeing tons of bitswap stream resets

[renaynay]

Seeing these logs quite frequently, both on BNs and LNs on mainnet (dating back to versions below v0.12.3)

2024-01-11T15:13:41.755Z        INFO    bitswap-server  server/server.go:547    Bitswap Client ReceiveError: stream reset
2024-01-11T15:13:41.762Z        INFO    bitswap-server  server/server.go:547    Bitswap Client ReceiveError: stream reset
2024-01-11T15:13:41.763Z        INFO    bitswap-server  server/server.go:547    Bitswap Client ReceiveError: stream reset

Weird considering it's a "client" error and BNs are seeing it.

[Wondertan]

Weird considering it's a "client" error and BNs are seeing it.

Is it? The log says its bitswap-server

[renaynay]

Yeah i see that it's coming from the server component but why is the error Bitswap Client ReceiveError ?

[Wondertan]

They might meant its coming "from a client" cc @Jorropo

The stream reset might come from multiple sources, and it is hard to know what's causing this. I think we need more bit swap server debug logs or info from the client side to continue debugging this.

[Jorropo]

> git grep "Bitswap Client ReceiveError"
bitswap/bitswap.go:     log.Infof("Bitswap Client ReceiveError: %s", err)
bitswap/client/client.go:       log.Infof("Bitswap Client ReceiveError: %s", err)
bitswap/server/server.go:       log.Infof("Bitswap Client ReceiveError: %s", err)

There used to only be one of them, but I copy pasted code around when splitting the server and client objects and didn't noticed this log message, it should be fixed.
If the logger says it's server then it's server.