Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test]: test DASing with different max block sizes and amount of light nodes #266

Closed
Tracked by #602
renaynay opened this issue Dec 6, 2021 · 8 comments
Closed
Tracked by #602
Assignees
Labels
area:block Raw blocks and erasure coded blocks area:das Related to DASer area:shares Shares and samples

Comments

@renaynay
Copy link
Member

renaynay commented Dec 6, 2021

No description provided.

@renaynay renaynay added the area:shares Shares and samples label Dec 6, 2021
@renaynay renaynay moved this to TODO in Celestia Node Dec 6, 2021
@adlerjohn
Copy link
Member

It would be nice if we could also test even larger block sizes than the current maximum to see where things start breaking down.

@renaynay
Copy link
Member Author

renaynay commented Dec 7, 2021

@adlerjohn Can you provide some specs for the tests you'd like to see run? Like

test 1: block size of ______
test 2: block size of ______, with _____ light nodes running in the network

etc.

@Wondertan
Copy link
Member

Simple testing by sending payForMessage with 32 square width succeeds:
image

Tested using a simple utility made by @evan-forbes in https://github.com/celestiaorg/celestia-app/blob/evan/mock-block-cmd/cmd/mock-blocks/main.go#L21.

@Bidon15, this might be highly relevant for you to test getSharesByNamespace in the real network environment. As a side goal, I would recommend forking the branch above and extending the CLI to allow more customization with CLI, so you can specify what square size you want. Also, would be cool if CLI can automatically detect RPC addresses so you won't need to specify it every time.

@Wondertan
Copy link
Member

#276

@adlerjohn
Copy link
Member

adlerjohn commented Dec 9, 2021

A matrix of tests:

  1. ODS 64x64x256 bytes (i.e. 1MiB blocks)
  2. ODS 256x256x256 bytes (i.e. 16 MiB blocks)

With

  1. 10 nodes
  2. 100 nodes
  3. 1000 nodes

@renaynay
Copy link
Member Author

@Bidon15 can you track these desired testcases somewhere so that we don't forget about them? We don't have to do them now, but maybe a nice way to show desired testcases, what we've completed so far, the results of those completed tests, and what is still left TODO + small description on any blockers to running the tests.

@renaynay renaynay moved this from TODO to Done in Celestia Node Dec 10, 2021
@Wondertan
Copy link
Member

https://github.com/celestiaorg/celestia-app/blob/evan/mock-block-cmd/cmd/mock-blocks/main.go#L66 - the code states that it is maxed size, while it was only 32x32

@Bidon15 Bidon15 assigned Bidon15 and unassigned Wondertan Mar 28, 2022
@Bidon15 Bidon15 added area:block Raw blocks and erasure coded blocks area:das Related to DASer labels Mar 28, 2022
@Bidon15 Bidon15 moved this from Done to TODO in Celestia Node Mar 28, 2022
@Bidon15 Bidon15 changed the title [test]: test DASing with max block size on devnet [test]: test DASing with different max block sizes and amount of light nodes Mar 28, 2022
@Bidon15 Bidon15 moved this from TODO to In Progress in Celestia Node Sep 2, 2022
@renaynay
Copy link
Member Author

closed in favour of #7

Repository owner moved this from In Progress to Done in Celestia Node Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:block Raw blocks and erasure coded blocks area:das Related to DASer area:shares Shares and samples
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants