-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test]: test DASing with different max block sizes and amount of light nodes #266
Comments
It would be nice if we could also test even larger block sizes than the current maximum to see where things start breaking down. |
@adlerjohn Can you provide some specs for the tests you'd like to see run? Like
etc. |
Simple testing by sending payForMessage with 32 square width succeeds: Tested using a simple utility made by @evan-forbes in https://github.com/celestiaorg/celestia-app/blob/evan/mock-block-cmd/cmd/mock-blocks/main.go#L21. @Bidon15, this might be highly relevant for you to test getSharesByNamespace in the real network environment. As a side goal, I would recommend forking the branch above and extending the CLI to allow more customization with CLI, so you can specify what square size you want. Also, would be cool if CLI can automatically detect RPC addresses so you won't need to specify it every time. |
A matrix of tests:
With
|
@Bidon15 can you track these desired testcases somewhere so that we don't forget about them? We don't have to do them now, but maybe a nice way to show desired testcases, what we've completed so far, the results of those completed tests, and what is still left TODO + small description on any blockers to running the tests. |
https://github.com/celestiaorg/celestia-app/blob/evan/mock-block-cmd/cmd/mock-blocks/main.go#L66 - the code states that it is maxed size, while it was only 32x32 |
closed in favour of #7 |
No description provided.
The text was updated successfully, but these errors were encountered: