Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tx consumes more gas in case of set GranterFee #3258

Closed
vgonkivs opened this issue Apr 4, 2024 · 4 comments · Fixed by #3385
Closed

Tx consumes more gas in case of set GranterFee #3258

vgonkivs opened this issue Apr 4, 2024 · 4 comments · Fixed by #3385
Labels
WS: BestTxs Reliable and seamless transaction flow

Comments

@vgonkivs
Copy link
Member

vgonkivs commented Apr 4, 2024

I'm currently working on enabling GrantFee functionality in celestia-node for SubmitPFB transactions and I'm observing that the gas estimation is not working as I'm getting "out of gas" each time I set a tx granter.
@cmwaters
Copy link
Contributor

cmwaters commented Apr 4, 2024

Yeah, the model for estimating works on the assumption that there are no added options to the transaction i.e. it's just a vanialla PFB

@Bidon15 Bidon15 added the WS: BestTxs Reliable and seamless transaction flow label Apr 4, 2024
@Bidon15
Copy link
Member

Bidon15 commented Apr 4, 2024

Yeah, the model for estimating works on the assumption that there are no added options to the transaction i.e. it's just a vanilla PFB

So does it mean this is node issue or app?

@cmwaters
Copy link
Contributor

cmwaters commented Apr 5, 2024

Its an app issue. The best short term solution is to use the EstimateGas on signer or SimulateTx via grpc which should provide an accurate gas estimate

@cmwaters
Copy link
Contributor

Ref: #3342

@vgonkivs vgonkivs mentioned this issue Apr 25, 2024
Merged
rootulp pushed a commit that referenced this issue Apr 26, 2024
@vgonkivs @rach-id
feat: introduce gas multiplier to increase gas limit (#3385)
32e7015 
## Overview
Resolves #3258

---------

Co-authored-by: CHAMI Rachid <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
WS: BestTxs Reliable and seamless transaction flow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: introduce gas multiplier to increase gas limit vgonkivs/celestia-app
3 participants
@Bidon15 @cmwaters @vgonkivs