Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to stop using the txbuilder more than once #144

Closed
evan-forbes opened this issue Nov 4, 2021 · 0 comments · Fixed by #175
Closed

Refactor to stop using the txbuilder more than once #144

evan-forbes opened this issue Nov 4, 2021 · 0 comments · Fixed by #175
Assignees
Labels
bug Something isn't working

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Nov 4, 2021

When creating MsgWirePayForMessages, we currently use the same txbuilder more than once. https://github.com/celestiaorg/lazyledger-app/blob/3192328a0952e6542395263fedc57b66c265ff79/x/payment/types/wirepayformessage.go#L47-L51

This will result in the generation of transactions that contain multiple messages when we only want one. We also need to modify this test to ensure that this works with multiple square sizes

PS: I think that merging such a large PR in #129 contributed to sneaking this bug in. Perhaps if I would have broken that PR up or if we would have had more time, then we would have caught this before hand.

@evan-forbes evan-forbes added the bug Something isn't working label Nov 4, 2021
@evan-forbes evan-forbes self-assigned this Nov 4, 2021
@evan-forbes evan-forbes mentioned this issue Nov 29, 2021
34 tasks
@liamsi liamsi moved this to testnet in Celestia Node Dec 2, 2021
@evan-forbes evan-forbes changed the title Refactor to stop using the txbuilder more than once Jan 12, 2022
@evan-forbes evan-forbes moved this from TODO to In Review in Celestia Node Jan 13, 2022
@adlerjohn adlerjohn linked a pull request Jan 13, 2022 that will close this issue
2 tasks
Repository owner moved this from In Review to Done in Celestia Node Jan 14, 2022
@adlerjohn adlerjohn moved this from Done to TODO in Celestia Node May 29, 2022
@adlerjohn adlerjohn moved this from TODO to Done in Celestia Node May 29, 2022
@adlerjohn adlerjohn changed the title Refactor to stop using the txbuilder more than once May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant