Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for generating transactions via the CLI #133

Closed
evan-forbes opened this issue Oct 8, 2021 · 1 comment
Closed

Add more tests for generating transactions via the CLI #133

evan-forbes opened this issue Oct 8, 2021 · 1 comment

Comments

@evan-forbes
Copy link
Member

If we would have had more tests that use the cli to generate transactions, then we would have noticed #132 sooner. The way we generate MsgWirePayForMessages is atypical for an cosmos-sdk chain in that we are actually generating and signing multiple iterations of the same transaction. We need to have better testing for this.

This should be completed either when completing #132 or directly after, as completing that will require a refactor of the current way we generate transactions using the cli.

@evan-forbes evan-forbes changed the title Add more tests using the cli Add more tests for generating transactions via the CLI Oct 8, 2021
@evan-forbes
Copy link
Member Author

closing with #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant