Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better source locations for evaluation errors ~and entity-parsing errors~ #485

Closed
1 of 2 tasks
cdisselkoen opened this issue Dec 8, 2023 · 1 comment
Closed
1 of 2 tasks

Better source locations for evaluation errors ~and entity-parsing errors~ #485

cdisselkoen opened this issue Dec 8, 2023 · 1 comment
Labels
3.1 Features for 3.1 papercut Small annoyances in the Cedar SDK. Lower priority fixes than bugs. Smaller than a fature request

Comments

@cdisselkoen
Copy link
Contributor

Category

Internal refactors/changes

Describe the feature you'd like to request

Similar to #174 for schema parsing errors, we can make similar improvements to reporting source locations in evaluation errors, entity-parsing errors, and elsewhere. Especially now that #477 is merged.

Describe alternatives you've considered

We've basically committed to doing this in #182 / #477

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
@cdisselkoen cdisselkoen added backlog internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice labels Dec 8, 2023
@cdisselkoen cdisselkoen mentioned this issue Dec 19, 2023
Merged
3 tasks
@sarahcec sarahcec added the 3.1 Features for 3.1 label Jan 3, 2024
@sarahcec sarahcec added papercut Small annoyances in the Cedar SDK. Lower priority fixes than bugs. Smaller than a fature request and removed internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice labels Jan 5, 2024
@cdisselkoen cdisselkoen mentioned this issue Jan 12, 2024
Merged
3 tasks
@sarahcec sarahcec moved this from Pending to In Progress in Cedar 4.0 Status Jan 23, 2024
@cdisselkoen
Copy link
Contributor Author

Splitting this issue into two:

This issue (#485) will be only for source locations in evaluation errors. That work was completed in #582, and as such, this issue will be closed.

A new issue (#599) covers source locations in "entity-parsing errors and elsewhere" as this issue's description puts it.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Cedar 4.0 Status Jan 24, 2024
@cdisselkoen cdisselkoen changed the title Better source locations for evaluation errors and entity-parsing errors Better source locations for evaluation errors ~and entity-parsing errors~ Jan 24, 2024
@cdisselkoen cdisselkoen mentioned this issue Aug 6, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.1 Features for 3.1 papercut Small annoyances in the Cedar SDK. Lower priority fixes than bugs. Smaller than a fature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdisselkoen @sarahcec