Skip to content

axum feature flag #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lcmgh opened this issue Nov 20, 2023 · 1 comment
Open

axum feature flag #43

lcmgh opened this issue Nov 20, 2023 · 1 comment

Comments

@lcmgh
Copy link

lcmgh commented Nov 20, 2023

Hi!

There is a tonic feature flag. I argue that there should be a axum feature flag that is activated by default to not force tonic only users to fetch axum dependencies.

What do you think?
@dsgallups dsgallups mentioned this issue Dec 31, 2023
Merged
@sjoerdsimons
Copy link
Contributor

fwiw while this could be easily done especially with #54, tonic itself depends on axum so you'd get it in some parts anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sjoerdsimons @lcmgh