-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Add documentation for ZX-calculus package and C++ API docs setup #817
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
=====================================
Coverage 92.3% 92.3%
=====================================
Files 127 127
Lines 13556 13555 -1
Branches 2086 2086
=====================================
+ Hits 12520 12522 +2
+ Misses 1036 1033 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look phenomenal ✨ many thanks for taking the time to add these docstrings!
I just browsed through them and added a couple of inline comments where I noticed that something might be slightly off. Hope these help.
Looking forward to seeing this in the online documentation!
Co-authored-by: Lukas Burgholzer <[email protected]> Signed-off-by: Tom Peham <[email protected]>
Co-authored-by: Lukas Burgholzer <[email protected]> Signed-off-by: Tom Peham <[email protected]>
Co-authored-by: Lukas Burgholzer <[email protected]> Signed-off-by: Tom Peham <[email protected]>
We use Doxygen and Breathe to include the C++ API.
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
this breaks sphinx-autobuild and creates an endless loop. Doxygen is now run once when the `docs` session is started or if the documentation build is running on RtD Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
it would really help if these examples were executed similarly to the Python notebooks... Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
…everted)" This reverts commit fa93c9f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. I played around with this a little more, tweaked a couple of things, and fixed a couple of smaller errors in the guide as well the general documentation.
To be honest, I am not yet fully happy with the Doxygen+Breathe solution here for the C++ API docs. Mostly because the resulting documentation lacks a lot of the structure that Doxygen actually provides in their HTML standalone builds and which I like very much.
However, I spent much more time today than I am willing to admit to find better alternatives, without much success. It seems that this is the current best practise for how to do this kind of documentation and better tooling needs to be developed first.
And regardless of whether this is the "perfect" solution, it is a big step forward in terms of documentation for the project and this PR most definitely has fulfilled its purpose.
I especially like the short, but on point, quickstart guide here.
Long story short: thank you for your work on this 🙏🏼. let's get it in now 🚀
Polishing the source code documentation and its presentation will be an ongoing effort over the coming weeks and months 🙌🏼
…ssion on Python 3.13 Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Description
This PR introduces documentation for the C++ ZX-calculus library.
It also adds the general infrastructure for C++ API documentation as part of the MQT Core project based on Doxygen and the
breathe
extension.Fixes #813
This change addresses concerns about missing documentation that came up in the revision openjournals/joss-reviews#7478.
Checklist: