Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtriage fail on loggraph #1031

Open
frankvm04 opened this issue Dec 5, 2024 · 2 comments
Open

xtriage fail on loggraph #1031

frankvm04 opened this issue Dec 5, 2024 · 2 comments

Comments

@frankvm04
Copy link

Calling xtriage with scaling.input.parameters.reporting.loggraphs=True fails. Looks identical to issue #970
I swear I don't sit here and test this one command hourly, but we do use it in our automated analysis runs.

Traceback (most recent call last):
  File "/opt/sbgrid/i386-mac/phenix/1.21.1-5286/phenix-1.21.1-5286/build/../modules/cctbx_project/mmtbx/command_line/xtriage.py", line 9, in <module>
    xtriage.run(args=sys.argv[1:])
  File "/opt/sbgrid/i386-mac/phenix/1.21.1-5286/phenix-1.21.1-5286/modules/cctbx_project/mmtbx/scaling/xtriage.py", line 1397, in run
    xtriage_results.show(out=graph_out)
  File "/opt/sbgrid/i386-mac/phenix/1.21.1-5286/phenix-1.21.1-5286/modules/cctbx_project/mmtbx/scaling/__init__.py", line 236, in show
    self._show_impl(out=out)
  File "/opt/sbgrid/i386-mac/phenix/1.21.1-5286/phenix-1.21.1-5286/modules/cctbx_project/mmtbx/scaling/xtriage.py", line 852, in _show_impl
    self.data_strength_and_completeness.show(out)
  File "/opt/sbgrid/i386-mac/phenix/1.21.1-5286/phenix-1.21.1-5286/modules/cctbx_project/mmtbx/scaling/__init__.py", line 236, in show
    self._show_impl(out=out)
  File "/opt/sbgrid/i386-mac/phenix/1.21.1-5286/phenix-1.21.1-5286/modules/cctbx_project/mmtbx/scaling/data_statistics.py", line 827, in _show_impl
    self.data_strength.show(out)
  File "/opt/sbgrid/i386-mac/phenix/1.21.1-5286/phenix-1.21.1-5286/modules/cctbx_project/mmtbx/scaling/__init__.py", line 236, in show
    self._show_impl(out=out)
  File "/opt/sbgrid/i386-mac/phenix/1.21.1-5286/phenix-1.21.1-5286/modules/cctbx_project/mmtbx/scaling/data_statistics.py", line 117, in _show_impl
    out.show_plot(self.table)
  File "/opt/sbgrid/i386-mac/phenix/1.21.1-5286/phenix-1.21.1-5286/modules/cctbx_project/mmtbx/scaling/__init__.py", line 217, in show_plot
    print("", file=self.out)
ValueError: I/O operation on closed file
@bkpoon
Copy link
Member

bkpoon commented Dec 11, 2024

Sorry, it is the same bug. I fixed it in the nightly builds, but I did not propagate it into the point releases. Can you try a nightly build from SBGrid? We are also in the process of getting the next release ready, so the fix will definitely be in the next release.

@frankvm04
Copy link
Author

I'll give it a try (but sure it will work) Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants