Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out what to do about PEcAn breaking allometry equations #28

Closed
Aariq opened this issue Mar 6, 2023 · 1 comment
Closed

Figure out what to do about PEcAn breaking allometry equations #28

Aariq opened this issue Mar 6, 2023 · 1 comment
Assignees

Comments

@Aariq
Copy link
Member

Aariq commented Mar 6, 2023

Currently PEcAn overwrites ED2 defaults with its own defaults resulting in errored runs.

The simplest fix is to just turn off this behavior from PEcAn and let ED2 use it's own defaults, but this will never be merged into the develop branch.

  1. Keep a fork/branch that we install PEcAn.ED2 from
  2. Try to fix PEcAn.ED2 in a less invasive way:
    • re-name ED2IN.r2.2.0.github to ED2IN.rgit so history.rgit is used for defaults
    • possibly edit ED2IN to use ED 2.2.0 defaults for everything (i.e. IMETRAD, IALLOM and ISTRUCT_GROWTH_SCHEME) (compare with what other ED2IN files in inst/ do)
    • update suspected bad values in history.rgit
@Aariq Aariq self-assigned this Mar 6, 2023
@Aariq
Copy link
Member Author

Aariq commented Mar 8, 2023

Not going to fix PEcAn.ED2 this time. We'll install from PR PecanProject/pecan#3125

@Aariq Aariq closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant