Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image jumps about when zooming #124

Open
rjgildea opened this issue Aug 5, 2019 · 8 comments
Open

Image jumps about when zooming #124

rjgildea opened this issue Aug 5, 2019 · 8 comments

Comments

@rjgildea
Copy link

rjgildea commented Aug 5, 2019

The image appears to be aligned with the left edge of the panel and consequently depending on the zoom level the image jumps about when changing zoom levels. It would be better if the image pixel under the mouse cursor remained under the cursor whatever the zoom level (like dials.image_viewer).

@dagewa
Copy link
Member

dagewa commented Aug 5, 2019

I think the mousewheel zoom behaves as intended, zooming in to the point under the cursor, whereas the zoom buttons lock to the left edge. So perhaps the zoom buttons could simply be made to run the function that is linked to the mousewheel?

@dagewa
Copy link
Member

dagewa commented Aug 5, 2019

Ok, I see the issue. I think the zoom button should keep the image centred, so the central pixel in the display window remains the central pixel. The mousewheel works correctly.

@rjgildea
Copy link
Author

rjgildea commented Aug 5, 2019

I am scrolling via the touchpad. Try zooming out far enough that there is grey space to the right of the image. Also at all zoom levels the image seem to randomly jump about when scrolling.

@rjgildea rjgildea closed this as completed Aug 5, 2019
@rjgildea rjgildea reopened this Aug 5, 2019
@rjgildea
Copy link
Author

rjgildea commented Aug 5, 2019

dui-image-zoom

@dagewa
Copy link
Member

dagewa commented Aug 5, 2019

I think I see what you mean... the zoom only keeps the pixel under the cursor in the same place when the image fills the width of the viewing window. I'm not sure if I see the jumping about, but I notice that when the cursor is off the side of the image then it operates the scrollbars instead

@dagewa
Copy link
Member

dagewa commented Aug 5, 2019

I'm not seeing the jumping clearly present in your animation, so maybe that's platform specific

@rjgildea
Copy link
Author

rjgildea commented Aug 5, 2019

There's a more subtle effect on linux (RHEL7), but on repeated zooming in and out on the same point (without moving the cursor) the image gradually drifts relative to the cursor.

@dagewa
Copy link
Member

dagewa commented Aug 5, 2019

Right, I see that too on Ubuntu. The image appears to drift to the lower right. This could possibly be related to other issues with the mask tool in which the centres of pixels are rounded to the upper left corner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants