Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug report 1.35.2 #275

Open
etybgm opened this issue Dec 6, 2023 · 3 comments
Open

bug report 1.35.2 #275

etybgm opened this issue Dec 6, 2023 · 3 comments
Labels

Comments

@etybgm
Copy link

etybgm commented Dec 6, 2023

1.35.2
Show inputs to recheck file name and folder name before downloading:
(C100) [焼肉定食 (ハラミ)] もしも担当アイドル北沢志保と付き合ったら 後編 (アイドルマスター ミリオンライブ!)
Completed:
(C100) [焼肉定食 (ハラミ)] もしも担当アイドル北沢志保と付き合ったら 後編 (アイドルマスター ミリオンライブ!).zip

~->_

@ccloli
Copy link
Owner

ccloli commented Dec 6, 2023

I remembered it's intended, probably because ~ is the user home directory on *nix, and can be used as short file name in DOS.

But I checked it just now, it seems that it's allowed on most systems. If it's fine then I'll remove it from disallowed symbols in next version.

@ccloli
Copy link
Owner

ccloli commented Sep 4, 2024

Checked the source code just now:

	var replaceList = {
		':': ':',
		'"': '"',
		'*': '*',
		'?': '?',
		'|': '|',
		'<': '<',
		'>': '>',
		'/': '/',
		'\\': '\',
		'\n': '-'
	};

Seems that ~ is not in the list, even in the first version which introduced the the feature.

image

Besides, the script replace these symbols into - instead of _. So I'm aware the filename is changed by the browser itself, not on the script side.

@ccloli ccloli added upstream and removed bug labels Sep 4, 2024
@etybgm
Copy link
Author

etybgm commented Sep 5, 2024

Can I replace the symbol ~ with the full-width ~ in script side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants