Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on implementing PingWebSocketFrame and PongWebSocketFrame #84

Open
devth opened this issue Jan 30, 2020 · 2 comments
Open

Thoughts on implementing PingWebSocketFrame and PongWebSocketFrame #84

devth opened this issue Jan 30, 2020 · 2 comments

Comments

@devth
Copy link

devth commented Jan 30, 2020

I'm consuming a websocket hosted on heroku which closes if there's no activity on the websocket in a timeout, usually 30 seconds. It looks like Netty has the concept of ping/pong for this purpose. Thoughts about implementing it in this lib?

@cch1
Copy link
Owner

cch1 commented Feb 19, 2020

Which version of Netty? This lib depends AHC which depends on Netty. But the version of AHC in use here (1.9.40) is not up-to-date and references netty 3.106. Updating AHC is not trivial but it is on the roadmap. WOudl you be interested in contributing to updating the AHC 2.X?

@devth
Copy link
Author

devth commented Feb 19, 2020

Ah, I see. It looks like ping/pong examples I've seen are for Netty 4:

I've since switched to https://github.com/schmee/java-http-clj since it already supports this (though it requires Java 11+).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants