(Non-critical) Error deploying app/xslt/helpers/analyse-journals.xsl

[olvidalo]

When trying to store analyse-journals.xsl in eXist during deployment, it fails with the following error:

[main] ERROR (NativeValueIndex.java [convertToAtomic]:1049) - org.exist.xquery.XPathException: exerr:ERROR Type error: string {current-grouping-key()} is not a valid xs:ID 

This is caused by lines 257, 333, 409, 485 (thanks @schlusslicht for pointing this out) which all contain:

<item xml:id="{current-grouping-key()}">

This confuses eXist's native value index which does not understand XSLT syntax, tries to validate the value "{current-grouping-key()}" as an xml:id and fails.

A possible workaround is to use the xsl:attribute constructor element instead of the @xml:id attribute directly, which should be equivalent:

<item>
  <xsl:attribute name="xml:id" select="current-grouping-key()"/>
   <!-- rest of the element content -->
</item>

However, it doesn't seem the file is used anywhere in the app. As the app deployment works regardless of the error, we could leave it like this. A nicer solution would be to either delete the file (if it's not used) or use the workaround outlined above, so the errors disappear. Let me know what you want to do, I can make a PR with the fix if you like.