322 Add big misses from all years #323
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damonamajor
requested review from
dfsnow,
wrridgeway and
jeancochrane
as code owners
Damonamajor
commented
Jan 10, 2025
| model_big_misses_full <- assessment_pin %>% | ||
| mutate(township_name = ccao::town_convert(meta_township_code)) %>% | ||
| filter( | ||
| meta_triad_code == run_triad_code, |
There was a problem hiding this comment.
Seems as though sv_outliers are filtered here,
model-res-avm/pipeline/00-ingest.R
Line 465 in 84708c4
Damonamajor
commented
Jan 10, 2025
| `Est. FMV` = pred_pin_final_fmv_round | ||
| ) %>% | ||
| mutate( | ||
| Difference = (`Est. FMV` - `Sale 1 Price`), |
There was a problem hiding this comment.
Do we want difference by max of any sale price
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finding erroneously priced sales led to issues such as #311, where we tried to identify incorrect data. This creates a new table which looks at all sales, and identifies the largest and smallest decreases in FMV to Sale Price (organized by township).
In essence, if we find a sale where the difference is $20,000,000, even if the sale was in 2018, that would be a pin where we might want to investigate if it should be an outlier / if something was input incorrectly.