Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how declaring methods final are done #2129

Closed
wolfieboy09 opened this issue Mar 4, 2025 · 3 comments
Closed

Change how declaring methods final are done #2129

wolfieboy09 opened this issue Mar 4, 2025 · 3 comments
Labels
area-Minecraft This affects CC's Minecraft-specific content. enhancement An extension of a feature or a new feature. wontfix A bug which I won't fix or an enhancement which won't be implemented.

Comments

@wolfieboy09
Copy link

I'm making a mod on 1.18.2 (it did not exist, so I might as well make it)

CC: T says I need to mark methods "final" (record class)
Image

I should not need to add "final" to methods that are final by default

@wolfieboy09 wolfieboy09 added the enhancement An extension of a feature or a new feature. label Mar 4, 2025
@SquidDev
Copy link
Member

SquidDev commented Mar 4, 2025

Thanks for the report! This has been fixed in recent versions of CC:T (1.109.1 I think, see 84a799d). I'm afraid you're out of luck if you're using 1.18 :/.

@SquidDev SquidDev closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2025
@SquidDev SquidDev added wontfix A bug which I won't fix or an enhancement which won't be implemented. area-Minecraft This affects CC's Minecraft-specific content. labels Mar 4, 2025
@wolfieboy09
Copy link
Author

No worries, I needed a thing for stoneblock 3, mod does not exist, so might as well make it.
Did not know if it did exist in more recent versions

@wolfieboy09
Copy link
Author

@SuppressWarnings("FinalMethodInFinalClass") will do the job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Minecraft This affects CC's Minecraft-specific content. enhancement An extension of a feature or a new feature. wontfix A bug which I won't fix or an enhancement which won't be implemented.
Projects
None yet
Development

No branches or pull requests

2 participants