Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computer/Pocket Computer file system protection #2043

Closed
m-doescode opened this issue Dec 29, 2024 · 6 comments
Closed

Computer/Pocket Computer file system protection #2043

m-doescode opened this issue Dec 29, 2024 · 6 comments
Labels
area-Core This affects CC's core (the Lua runtime, APIs, computer internals). enhancement An extension of a feature or a new feature. wontfix A bug which I won't fix or an enhancement which won't be implemented.

Comments

@m-doescode
Copy link

Excuse me if this has already been mentioned before, I tried but failed to find any issue relating to this.

Adding a setting to block mounting the computer's files through a disk drive. As you know, you can put a pocket computer or regular computer into a disk drive and any attached computer can then access this computer's files. This is fine, but it means that you can't really protect your computer from being infiltrated.

The idea is that a setting could be added, maybe fs.allow_drive_mounting. When added to a disk drive, the mod checks to see if this setting is set to false in the .settings file, and if so, refuses to mount the computer. This would effectively prevent any access to the computer unless you're the owner and know the password/entry sequence.

On the other hand, it gives a false sense of security. Your computer can always be griefed, not inspected, sure, but it can be broken and that's still just as bad. Also, it makes it seem like it's completely inaccessible but of course any server admin with server file access can read your files, so it may confuse players.

Finally, it breaks the principle that if you own the computer, you get to decide what it runs. What if you forgot to turn off disk startup and someone installs a virus on it? Now you can't recover it at all without an admin's help. Logically, if you have physical access, you should at least be able to wipe the computer to not have your gold go to waste (although it isn't really a lot of gold...)

All that said, it can still be useful if you trust your admins and have a mod similar to securitycraft that protects computers from being broken.

What do you think?

@m-doescode m-doescode added the enhancement An extension of a feature or a new feature. label Dec 29, 2024
@Lupus590
Copy link
Contributor

Lupus590 commented Dec 29, 2024

You could just encrypt your important files.
Also, don't put your pocket computer into untrusted disk drives.
Likewise, don't put untrusted disks into your disk drives.

@m-doescode
Copy link
Author

You could just encrypt your important files.

Ehhh not really much of a solution given how inefficient encryption is, and it's quite advanced for a simple player that just wants a a way to secure their computer.

Also, don't put your pocket computer into untrusted disk drives.

Sure, but what's stopping someone from mining your computer and putting it into one?

@zyxkad
Copy link
Contributor

zyxkad commented Dec 29, 2024

Sure, but what's stopping someone from mining your computer and putting it into one?

claims, or server rules

@zyxkad
Copy link
Contributor

zyxkad commented Dec 29, 2024

Logically, if you have physical access, you should at least be able to wipe the computer to not have your gold go to waste (although it isn't really a lot of gold...)

Yes, that's why you can access computer files in a disk drive without any permissions.

@SquidDev SquidDev added wontfix A bug which I won't fix or an enhancement which won't be implemented. area-Core This affects CC's core (the Lua runtime, APIs, computer internals). labels Jan 5, 2025
@SquidDev
Copy link
Member

SquidDev commented Jan 5, 2025

Woops, pressed enter too early, sorry!

Thank for the suggestion! I understand the motivation, but I'm afraid this is not something I want to add.

Finally, it breaks the principle that if you own the computer, you get to decide what it runs. What if you forgot to turn off disk startup and someone installs a virus on it?

I think this is the crux of it really. I think if you mess up your computer (either deliberately or accidentally), there needs to be a way to recover from it (well, short of just deleting the files). The ability to mount a computer in the drive is incredibly useful, and something I think that needs to always be available.

@m-doescode
Copy link
Author

Seems like a satisfactory conclusion has been reached, so I'll close the issue

@m-doescode m-doescode closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Core This affects CC's core (the Lua runtime, APIs, computer internals). enhancement An extension of a feature or a new feature. wontfix A bug which I won't fix or an enhancement which won't be implemented.
Projects
None yet
Development

No branches or pull requests

4 participants