Fix building context stack for inner elements of sections #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
- Coverage 85.77% 84.31% -1.46%
==========================================
Files 2 2
Lines 506 440 -66
==========================================
- Hits 434 371 -63
+ Misses 49 46 -3
Partials 23 23
Continue to review full report at Codecov.
|
|
Thanks @roblillack! |
This was referenced Jun 9, 2021
roblillack
added a commit
to roblillack/tack
that referenced
this pull request
Jun 10, 2021
This adds a bunch of fully integrated test sites. While here, fix some bugs: - Fix not being able to read `.md` or `.yaml` files instead of `.mkd` and `.yml`. #22 - Fix title casing. #3 - Fix iterate `siblings` in correct order. #4 - Fix crash for non-existent asset directories. #5 - Fix rendering section context. #8 (Needs cbroglie/mustache#54) - Fix rendering non-false value sections. #23 (Needs cbroglie/mustache#55) Also, add these features: - Allow the root index page to be defined with metadata and markup directly in `content/`. #19 - Add support for empty pages (no metadata or markup defined) if they have non-empty children. #20 - Add support for `children` to iterate non-floating child pages. #16 - Add support for `posts` to iterate all child pages marked with a date. #18 - Add support for `menu` sections to iterate all `siblings` and the current page (only for non-floating pages). #17 - For each entry of page collections (`children`, `menu`, `navigation`, `posts`, `siblings`) add `first` and `last` boolean values that can be used to construct better separators. #21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #53. When building the context stack for elements inside sections now, we're not starting with the outermost context anymore, but the innermost.
Two tests are added which test for the correct behavior here, all other tests still pass.