Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement]add 64bit version #28

Open
chenshaoju opened this issue Oct 17, 2022 · 13 comments
Open

[enhancement]add 64bit version #28

chenshaoju opened this issue Oct 17, 2022 · 13 comments

Comments

@chenshaoju
Copy link

Current cloak-android only has a 32-bit version, in some cases, the newest phone maybe not support it. [The Pixel 7 series might be the first 64-bit-only Android phones]

and some phones may show a warning message:
QQ图片20221017111546

Thanks for your hard work.

@fyrych
Copy link

fyrych commented Dec 2, 2022

Hi. Downloaded today, and cannot install this app. Is it possible to create a 64 bit version?
Pixel 7 Pro.

@bingzhangdai
Copy link

bingzhangdai commented Mar 21, 2023

Same here. I am wondering about the effort of migrating to 64 bit. Will build with 64 bit sdk but no code change work?

@fyrych
Copy link

fyrych commented Mar 21, 2023

Same here. I am wondering about the effort of migrating to 64 bit. Will build with 64 bit sdk but no code change work?

I am changed ROM, installed custom rom for my phone. Problem with 32bit solved.

@bingzhangdai
Copy link

Same here. I am wondering about the effort of migrating to 64 bit. Will build with 64 bit sdk but no code change work?

I am changed ROM, installed custom rom for my phone. Problem with 32bit solved.

Yes, I can install the x86 version, but there are some problems when launching the shadowsocks client with cloak plugin. Every time I have to manually open the cloak plugin then return to shadowsocks client (this leaves the cloak plugin running in the background), otherwise, the shadowsocks client won't start. It will complain "unknown plugin cloak". I suspect it is due to the compatibility problems of x86 version app.

@bingzhangdai
Copy link

I can see that the build script already compiles the arm64 version apk:

echo "Cross compiling ckclient for arm64"
. I think the owner can directly put the artifact to release page?

@bingzhangdai
Copy link

bingzhangdai commented Mar 22, 2023

These android-strip tools are removed from NDK so that the cross platform compile fails.

ANDROID_ARM64_STRIP=$ANDROID_PREBUILT_TOOLCHAIN/bin/aarch64-linux-android-strip
I commented these strip steps and manually built the apk. I can get the x64 version.

However, "unknown plugin ck-client" is still there.

@cbeuw
Copy link
Owner

cbeuw commented Mar 22, 2023

x86_64, arm, and arm64 versions of the native Go lib are included in every APK, so this shouldn't have been the issue.

I was not aware of APKs being architecture specific, I'll look into this.

@bingzhangdai
Copy link

@cbeuw This line failed

try "$ANDROID_ARM64_STRIP" ck-client
Commented these strip steps will work.
I suggest adding set -e in the beginning of the script to force this build step to fail in Azure DevOps. Then you can notice the error.

@cbeuw
Copy link
Owner

cbeuw commented Mar 22, 2023

This alone wouldn't fix the 32-bit APK issue, since existing releases were built successfully when NPK didn't remove strip

@bingzhangdai
Copy link

bingzhangdai commented Mar 22, 2023

Yes. I tried you project in Azure DevOps build. Actually your cross platform compile does fail.
image

You can add set -e in the beginning or simply use && between these commands
image

@cbeuw
Copy link
Owner

cbeuw commented Mar 22, 2023

Ah yes you are right, it's been failing the whole time...

I'll fix the build script and make a new release

@bingzhangdai
Copy link

btw, I found the solution to "unknown plugin": shadowsocks/shadowsocks-android#1428. It is not related to the x64 bit version.

@bingzhangdai
Copy link

@cbeuw Thank you. Another request, could you upload it to the play store? It will be more convenient, and the cellphone won't prompt the warning during installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants