Skip to content

Commit fed288e

Browse files
beccaelenzilkelsey-steven-adakyra-patton
authored
Apply suggestions from code review - fix typos
Co-authored-by: kelsey-steven-ada <[email protected]> Co-authored-by: Kyra Patton <[email protected]>
1 parent b8ade59 commit fed288e

File tree

5 files changed

+13
-9
lines changed

5 files changed

+13
-9
lines changed

ada-project-docs/testing.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
## Tests
22

3-
We will need to complete part of all of some of the tests for this project. If a test is incomplete, it will raise an `Exception`. You should comment out the `Exception` when implementing the test.
3+
We will need to complete part – or all of some of the tests for this project. If a test is incomplete, it will raise an `Exception`. You should comment out the `Exception` when implementing the test.
44

5-
You may with to review details about how to run tests [here](https://github.com/AdaGold/viewing-party#details-about-how-to-run-tests).
5+
You may wish to review details about how to run tests [here](https://github.com/AdaGold/viewing-party#details-about-how-to-run-tests).
66

77
Recall that it is always a good idea to search the file for any `@pytest.mark.skip` decorators you may have missed before moving to the next wave.
88

ada-project-docs/wave_01.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -181,11 +181,11 @@ As a client, if I make any of the following requests:
181181
* `UPDATE` `/tasks/<task_id>`
182182
* `DELETE` `/tasks/<task_id>`
183183

184-
and there is no exiting task with `task_id`
184+
and there is no existing task with `task_id`
185185

186186
The response code should be `404`.
187187

188-
You may chose the response body.
188+
You may choose the response body.
189189

190190
Make sure to complete the tests for non-existing tasks to check that the correct response body is returned.
191191

ada-project-docs/wave_03.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,6 @@ When I send a `PATCH` request to `/tasks/1/mark_complete` or a `PATCH` request t
127127

128128
Then I get a `404 Not Found`.
129129

130-
You may chose the response body.
130+
You may choose the response body.
131131

132132
Make sure to complete the tests for non-existing tasks to check that the correct response body is returned.

ada-project-docs/wave_05.md

+5-3
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ Our goal for this wave is to be able to create, read, update, and delete differe
1212

1313
## Writing Tests
1414

15-
This wave requires more testing writing.
16-
- As with incomplete test in other waves, you should comment out the `Exception` when implementing the test.
15+
This wave requires more test writing.
16+
- As with incomplete tests in other waves, you should comment out the `Exception` when implementing a test.
1717
- The tests you need to write are scaffolded in the `test_wave_05.py` file.
1818
- These tests are currently skipped with `@pytest.mark.skip(reason="test to be completed by student")` and the function body has `pass` in it. Once you implement these tests you should remove the `skip` decorator and the `pass`.
1919
- For the tests you write, use the requirements in this document to guide your test writing.
@@ -160,7 +160,9 @@ and there is no existing goal with `goal_id`
160160

161161
The response code should be `404`.
162162

163-
You may chose the response body.
163+
You may choose the response body.
164+
165+
Make sure to complete the tests for non-existing tasks to check that the correct response body is returned.
164166

165167
### Create a Goal: Invalid Goal With Missing Title
166168

ada-project-docs/wave_06.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -139,4 +139,6 @@ then I get this response:
139139

140140
`404 Not Found`
141141

142-
You may chose the response body.
142+
You may choose the response body.
143+
144+
Make sure to complete the tests for non-existing tasks to check that the correct response body is returned.

0 commit comments

Comments
 (0)