Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code audit #1

Open
cmutel opened this issue Oct 16, 2023 · 2 comments
Open

Code audit #1

cmutel opened this issue Oct 16, 2023 · 2 comments
Assignees

Comments

@cmutel
Copy link

cmutel commented Oct 16, 2023

We need to look through everywhere the AB touches Brightway, and choose from the following:

  • rewrite: Rewrite code to follow existing functionality in core Brightway libraries
  • incorporate: Take this functionality into core Brightway libraries
  • adapt: Adapt the current code to Brightway 2.5 standards
  • ignore: Current code is inline with Brightway 2.5 and doesn't need to be changed
  • imports: Current code is inline with Brightway 2.5, but import statement should switch from brightway2
  • delete: This code is unnecessary. For example, it duplicates existing functionality without adding anything.

Work is on bw25 branch of https://github.com/cauldron/activity-browser

@cmutel cmutel self-assigned this Oct 16, 2023
@tngTUDOR
Copy link

i started a list of such at the ab-compat-bw25 repo.

@cmutel
Copy link
Author

cmutel commented Oct 21, 2023

Comments should take form:

# BW25: incorporate

jsvgoncalves pushed a commit that referenced this issue Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants