Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save recording locally #50

Open
tejaskdubal opened this issue Sep 30, 2020 · 2 comments
Open

Save recording locally #50

tejaskdubal opened this issue Sep 30, 2020 · 2 comments

Comments

@tejaskdubal
Copy link

tejaskdubal commented Sep 30, 2020

First of all, Thanks for this awesome library.

Question/Problem -
Is it possible to save video locally in a device irrespective of the network state?

Please go through the following cases -

  1. User is not able to connect the device with the network.
  2. Streaming is interrupted by the network/server issue.
  3. Streaming is interrupted by network/server issues and not able to re-stream at all.

This could be a solution -
Provide an option that allows users to save the recording locally with a specific name.

Thanks.

@thmatuza
Copy link
Contributor

thmatuza commented Oct 1, 2020

Yes, if you uncomment this, you can save video locally in a device.
https://github.com/cats-oss/VideoCast-Swift/blob/0.1.5/Source/Api/iOS/VCSimpleSessionImpl.swift#L232-L244

It will pass an output of the encoder to both the network and storage.

I was thinking about that case, too.
Above code works ok though, my ideal is like this.

  1. Encoding h264 and streaming it via RTMP with relatively low video quality
  2. Encoding h265 and saving it locally with high video quality

I will probably work on it sometime this year.

@tejaskdubal
Copy link
Author

Ok, thanks for the immediate response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants