Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for div.sv can fail if RESULT_WIDTH < INPUT_WIDTH #1

Open
catkira opened this issue Mar 21, 2023 · 0 comments
Open

test for div.sv can fail if RESULT_WIDTH < INPUT_WIDTH #1

catkira opened this issue Mar 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@catkira
Copy link
Owner

catkira commented Mar 21, 2023

This happens for example for the settings

RESULT_WIDTH = 16
INPUT_WIDTH = 32 
numerator = 3698210746
denominator = 9845

-> https://github.com/catkira/open5G_rx/tree/div_bug
I think it its not so urgent/relevant for the receiver, because in atan2.sv, which is the only place where div.sv is used, RESULT_WIDTH = INPUT_WIDTH. Nevertheless it should be handled in some way. Moreover, the test currently fails only sometimes, because test values are chosen randomly without a fixed seed.

@catkira catkira added the bug Something isn't working label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant