Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a check that package.xml declared a build dependency on catkin_simple #10

Open
tfoote opened this issue Oct 17, 2013 · 2 comments
Open

Comments

@tfoote
Copy link
Contributor

tfoote commented Oct 17, 2013

We do this in catkin and it saves a lot of easy mistakes. Catkin simple could do the same.

What catkin says.

CMake Error at /opt/ros/hydro/share/catkin/cmake/catkin_package.cmake:112 (message):
  catkin_package() 'catkin' must be listed as a buildtool dependency in the
  package.xml
Call Stack (most recent call first):
  /opt/ros/hydro/share/catkin/cmake/catkin_package.cmake:98 (_catkin_package)
  /home/tfoote/work/trailmix/devel/share/catkin_simple/cmake/catkin_simple-extras.cmake:170 (catkin_package)
  Redwood/3rdparty/gflags_catkin/CMakeLists.txt:34 (cs_export)
@wjwwood
Copy link
Member

wjwwood commented Oct 17, 2013

If you don't have a build dependency on catkin_simple, then catkin_simple isn't guaranteed to be there, so it will more likely fail on find_package(catkin_simple REQUIRED).

@wjwwood wjwwood changed the title add a check that package.xml declared a build dependency on catkin_simpl add a check that package.xml declared a build dependency on catkin_simple Mar 27, 2014
@NikolausDemmel
Copy link
Member

I will try to add such a check in #31. Note that in that light solving ros/catkin#789 would be nice such that catkin_simple packages would not need to declare both buildtool-dependencies on catkin and catkin_simple. catkin_simple should be enough ideally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants