Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with Arabic Wikipedia for "hero" elements #31

Open
soulgalore opened this issue Dec 11, 2019 · 0 comments
Open

Problems with Arabic Wikipedia for "hero" elements #31

soulgalore opened this issue Dec 11, 2019 · 0 comments

Comments

@soulgalore
Copy link
Contributor

Hi Patrick,
I've got a problem with testing the Arabic version of Wikipedia. The hero elements can't handle the arabic characters.

In the Visual Metrics log it looks like this:

14:57:17.282 - Calculating hero element times
14:57:17.282 - 'ascii' codec can't decode byte 0xd8 in position 96: ordinal not in range(128)
Traceback (most recent call last):
  File "/usr/src/app/node_modules/browsertime/vendor/visualmetrics.py", line 1880, in main
    options.herodata)
  File "/usr/src/app/node_modules/browsertime/vendor/visualmetrics.py", line 1342, in calculate_visual_metrics
    'value': calculate_hero_time(progress, dirs, hero, viewport)})
  File "/usr/src/app/node_modules/browsertime/vendor/visualmetrics.py", line 1543, in calculate_hero_time
    logging.debug('Target image for hero %s is %s' % (hero['name'], target_frame))
UnicodeDecodeError: 'ascii' codec can't decode byte 0xd8 in position 96: ordinal not in range(128)

I've tested directly on WebPageTest and get the same error there:
https://webpagetest.org/result/191211_J8_e69430ffc54e243dae4fa05d5de4b894/

Best
Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant