Capabilities setting to allow user evaluate others but not themself

[logicexpertise]

Hi,

There is no combination of mod/ojt:evaluate and mod/ojt:evaluateself that would enable a user to be able to evaluate others but not evaluate themself.

The issue is with the return value of the function ojt_can_evaluate() -

totara-mod-ojt/locallib.php

Line 340 in a91ead6

function ojt_can_evaluate($userid, $context) {

Currently the return value of that function is as indicated in the truth table below (note, in the scenario under consideration, $USER->id == $userid):

ojt:evaluate	ojt:evaluateself	function returns
TRUE	TRUE	TRUE
TRUE	FALSE	TRUE
FALSE	TRUE	TRUE
FALSE	FALSE	FALSE

The function should return false for the combination in the second line of the above table, ie. TRUE && FALSE should return FALSE.

BTW, the next line, FALSE && TRUE, should also return FALSE, however returning TRUE as the function currently does could be justified on the premise that there may be cases (unlikely) where a user should not be able to evaluate others but be able to evaluate themself.

[danmarsden]

Hey Olumuyiwa, thanks for the report - feel free to submit a PR and we'll take a look!