Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests: scheduled_tasks install.xml does not have correct permissions #103

Open
kristian-94 opened this issue Mar 12, 2020 · 3 comments

Comments

@kristian-94
Copy link

This recent commit:
155adac

Modified file permissions when it shouldn't have. We need to change this back to 644 for the install.xml file and 755 for the db directory.

kristian-94 pushed a commit that referenced this issue Mar 12, 2020
@kristian-94
Copy link
Author

@danmarsden I made a mistake with the last change, and left the file permissions as 777. This looks to be passing travis, when it's green can I merge it?

danmarsden added a commit that referenced this issue Mar 12, 2020
@danmarsden
Copy link
Member

Whoops - I should have caught that too!! I've hit that a few times myself too!

@kristian-94
Copy link
Author

Yes, locally you have to change the permissions to let moodle do the save action, but have to remember to change it back after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants