-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit redirecting only to local or whitelisted domains #97
Comments
I would treat the open redirect as a bug and fix that, and treat the whitelist as a bonus points new feature - yes it worked in the past but its an undocumented bug rather than an explicit feature |
Agree we should fix it brutally by limiting to local URLs only and leave this one open as an enhancement for those who may be suffering. |
After landing #99 we are redirecting only to internal pages. Which is not ideal and can potentially break some functionality. Next step would be introducing a new setting for whitelisting domains for redirecting. |
Currently on logout you can redirect to any URL. Would be more secure to redirect only to internal pages and whitelisted pages. I guess we need a new setting for that.
The text was updated successfully, but these errors were encountered: