Eia860m eia923 q1 2025 #4047
Eia860m eia923 q1 2025 #4047
Conversation
aesharpe
added
eia923
| @@ -1552,6 +1552,7 @@ | |||
| "rr": "RR", | |||
| "pl": "PL", | |||
| "rv": "RV", | |||
| "RT": "TR", # This is based on a guess. No definitive proof. Culprit is plant_id_eia 3935 in October 2024 in the coalmine table. | |||
There was a problem hiding this comment.
I tried to see what the other rows from the same coalmine listed as the primary transportation method to see if there was a clear fix here; sadly there was not. Entries from older years say "RV" and newer years say "TR". I chose TR because it's "RT" backwards....also it only affects two entires so it's a very minimal issue.
| * Run quarterly updates for 2025 Q1 including new EIA860m data from 2024-10 through | ||
| 2024-12. | ||
|
|
||
| EIA 923 | ||
| ~~~~~~~ | ||
| * Run quarterly updates for 2025 Q1 including new EIA 923 data from 2024-09 through | ||
| 2024-11. |
There was a problem hiding this comment.
this is totally a nit! but we seem to have almost always said "added X...". I would also find the Q# but with these months confusing as an outside person.
| * Run quarterly updates for 2025 Q1 including new EIA860m data from 2024-10 through | |
| 2024-12. | |
| EIA 923 | |
| ~~~~~~~ | |
| * Run quarterly updates for 2025 Q1 including new EIA 923 data from 2024-09 through | |
| 2024-11. | |
| * Added EIA 860m through December 2024. See :issue:`4038` and pr:`4047`. | |
| EIA 923 | |
| ~~~~~~~ | |
| * Added EIA 923 monthly data through September 2024. See :issue:`4038` and pr:`4047`. |
There was a problem hiding this comment.
i don't think adding in the pudl plant id mapping will change these diffs, but i think we normally suggest doing that mapping before updating these validation tests. to attempt a lightweight small test after the id's are mapped you could first initialize the glue assets and then initialize one of the more processed tables like gens_eia860
There was a problem hiding this comment.
also you'll probably want to fully re-run these guys anyway given the new archive. oh i see that you've updated these with the new doi already
There was a problem hiding this comment.
i believe you checked in this ~$ version of this file. if i understand correctly this just means you had the file open. you should save it, close it and then check in the non open version of this file and delete this guy
Overview
Closes #4038
What problem does this address?
Adds new monthly data from EIA860m and EIA923
What did you change?
Documentation
Make sure to update relevant aspects of the documentation.
Tasks
Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list