From 8185bfa41f9b7d373fac4511456800ae46ecc9c2 Mon Sep 17 00:00:00 2001 From: Devanshu Date: Tue, 5 Nov 2024 13:31:17 +0530 Subject: [PATCH] Return from RunWithCancel if cmd is kapp Signed-off-by: Devanshu --- cli/pkg/kctrl/cmd/app/release/release_cmd_runner.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cli/pkg/kctrl/cmd/app/release/release_cmd_runner.go b/cli/pkg/kctrl/cmd/app/release/release_cmd_runner.go index 6d5674dc8..0db52b5a0 100644 --- a/cli/pkg/kctrl/cmd/app/release/release_cmd_runner.go +++ b/cli/pkg/kctrl/cmd/app/release/release_cmd_runner.go @@ -35,9 +35,6 @@ func (r ReleaseCmdRunner) Run(cmd *goexec.Cmd) error { r.ui.PrintHeaderText("Building images and resolving references") } - if filepath.Base(cmd.Path) == "kapp" { - return nil - } if filepath.Base(cmd.Path) == "kbld" { cmd.Args = append(cmd.Args, fmt.Sprintf("--imgpkg-lock-output=%s", r.tempImgLockFilepath)) } @@ -57,6 +54,10 @@ func (r ReleaseCmdRunner) Run(cmd *goexec.Cmd) error { } func (r ReleaseCmdRunner) RunWithCancel(cmd *goexec.Cmd, cancelCh chan struct{}) error { + if filepath.Base(cmd.Path) == "kapp" { + return nil + } + if r.fullOutput { cmd.Stdout = io.MultiWriter(r.log, cmd.Stdout) cmd.Stderr = io.MultiWriter(r.log, cmd.Stderr)