Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABI Parameters spec can be created/updated with invalid parameters #297

Open
nevendyulgerov opened this issue Jan 13, 2025 · 0 comments
Open
Assignees
Labels
apps: web Type: Bug Something isn't working

Comments

@nevendyulgerov
Copy link
Contributor

nevendyulgerov commented Jan 13, 2025

🙂 Expected behavior

The ABI Parameters spec form should not accept invalid parameters when creating or updating it.

🫠 Actual behavior

The ABI Parameters spec form allow invalid parameters when creating or updating it.

🧪 Minimal test case

  1. Open the /specifications/new page
  2. Fill in a name for the spec
  3. In the ABI Parameter input, insert invalid abi-spec
  4. Click the Add button and notice the error that appears under the field - Unknown type. Type "invalid abi-spec" is not a valid ABI type. Version: [email protected].
  5. Click the Save button

After step 5 the spec is created successfully although there's an error for the ABI parameters. Updating the same spec with invalid parameters works just the same.

🌎 Environment

Any environment. Any Rollups version.

✔️ Possible solutions

The Add button (from step 4) should not allow inserting invalid ABI parameters. The validation for this should be triggered at this phase, rather than later when the ABI parameter is already added.

@nevendyulgerov nevendyulgerov added Type: Bug Something isn't working apps: web labels Jan 13, 2025
@github-project-automation github-project-automation bot moved this to 📌 Todo in Explorer Unit Jan 13, 2025
@nevendyulgerov nevendyulgerov self-assigned this Jan 13, 2025
@nevendyulgerov nevendyulgerov changed the title ABI Parameters spec can be created/update with invalid parameters ABI Parameters spec can be created/updated with invalid parameters Jan 13, 2025
@nevendyulgerov nevendyulgerov moved this from 📌 Todo to 🧑‍💻 In Progress in Explorer Unit Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: web Type: Bug Something isn't working
Projects
Status: 🧑‍💻 In Progress
Development

No branches or pull requests

1 participant