You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ABI Parameters spec form should not accept invalid parameters when creating or updating it.
🫠 Actual behavior
The ABI Parameters spec form allow invalid parameters when creating or updating it.
🧪 Minimal test case
Open the /specifications/new page
Fill in a name for the spec
In the ABI Parameter input, insert invalid abi-spec
Click the Add button and notice the error that appears under the field - Unknown type. Type "invalid abi-spec" is not a valid ABI type. Version: [email protected].
Click the Save button
After step 5 the spec is created successfully although there's an error for the ABI parameters. Updating the same spec with invalid parameters works just the same.
🌎 Environment
Any environment. Any Rollups version.
✔️ Possible solutions
The Add button (from step 4) should not allow inserting invalid ABI parameters. The validation for this should be triggered at this phase, rather than later when the ABI parameter is already added.
The text was updated successfully, but these errors were encountered:
nevendyulgerov
changed the title
ABI Parameters spec can be created/update with invalid parameters
ABI Parameters spec can be created/updated with invalid parameters
Jan 13, 2025
🙂 Expected behavior
The ABI Parameters spec form should not accept invalid parameters when creating or updating it.
🫠 Actual behavior
The ABI Parameters spec form allow invalid parameters when creating or updating it.
🧪 Minimal test case
/specifications/new
pageABI Parameter
input, insertinvalid abi-spec
Add
button and notice the error that appears under the field -Unknown type. Type "invalid abi-spec" is not a valid ABI type. Version: [email protected]
.Save
buttonAfter step 5 the spec is created successfully although there's an error for the ABI parameters. Updating the same spec with invalid parameters works just the same.
🌎 Environment
Any environment. Any Rollups version.
✔️ Possible solutions
The
Add
button (from step 4) should not allow inserting invalid ABI parameters. The validation for this should be triggered at this phase, rather than later when the ABI parameter is already added.The text was updated successfully, but these errors were encountered: