Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tools writebe64 and readbe64 depends on Lua, but Lua is not bundled #8

Open
mpolitzer opened this issue May 16, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mpolitzer
Copy link
Collaborator

The writebe64 and readbe64 tools depends on Lua, and the tools repository does not bundle Lua. Using them will give an error in distributions without Lua installed. We have to come up with a solution, maybe rewrite the tool in C or Rust? Or bundle Lua? Or can we live without these tools?

@edubart edubart added the enhancement New feature or request label May 30, 2023
@vfusco vfusco self-assigned this Apr 18, 2024
@vfusco
Copy link
Contributor

vfusco commented Apr 18, 2024

Lua is already present on the filesystem https://github.com/cartesi/machine-emulator-tools/blob/main/fs/Dockerfile#L45

@vfusco vfusco closed this as completed Apr 18, 2024
@edubart
Copy link
Contributor

edubart commented Apr 18, 2024

Lua is already present on the filesystem

But not a dependency of the tools.deb yet, people are installing the tools on their own and not following our Dockerfile and having broken stuff, like the busybox issue in #43

I think we should get rid of needing Lua on tools, and do like Diego did with the hex tool that is made in C++.

@edubart edubart reopened this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants