Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IDataProvider #80

Open
guidanoli opened this issue Oct 21, 2024 · 0 comments · May be fixed by #81
Open

Refactor IDataProvider #80

guidanoli opened this issue Oct 21, 2024 · 0 comments · May be fixed by #81
Assignees

Comments

@guidanoli
Copy link
Contributor

guidanoli commented Oct 21, 2024

As of now, the implementation of the gio function in the DaveConsensus contract uses a hard-coded tree height that covers 2 MB, but what we should do, instead is:

  • Compute the Merkle tree of the smallest tree that fits the response data
  • This tree must encompass at least 32 bytes
  • The function should return, besides the Merkle root, the size of the response data (in bytes)

As it is already implemented, when computing the Merkle root of the response data, we should pad it with zeros to the next power of 2.

@guidanoli guidanoli self-assigned this Oct 21, 2024
@guidanoli guidanoli linked a pull request Oct 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant