Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home page could use a photo and short summary #527

Closed
raynamharris opened this issue Oct 11, 2017 · 8 comments
Closed

home page could use a photo and short summary #527

raynamharris opened this issue Oct 11, 2017 · 8 comments
Labels
bug-bbq Good for Bug BBQ pr-requested

Comments

@raynamharris
Copy link
Contributor

You know how paste a hyperlink to a website on social media, sometimes you get a little pop-up window with a photo and some text from the website? Here are two examples of pop-ups from the instructor training website.

screen shot 2017-10-11 at 2 34 15 pm

screen shot 2017-10-11 at 2 36 11 pm

I think we could improve our home page by adding:

  1. a single image with both the SWC and DC logos
  2. an opening sentence that states the mission/vision/purpose/objective of instructor training.

What do you think? Does anyone else agree that we should add these two things

@weaverbel
Copy link
Contributor

I agree @raynamharris but won't volunteer to try to add images as that won't end well!

@ChristinaLK
Copy link
Contributor

I agree, if we can figure out how to produce the outcome you're looking for. @raynamharris do you know if we need to tag/flag that material specifically? Does it go in the header?

@fmichonneau
Copy link
Contributor

Resources for facebook are listed here: https://developers.facebook.com/docs/sharing/webmasters and for twitter here: https://developer.twitter.com/en/docs/tweets/optimize-with-cards/guides/getting-started

From a quick glance, it looks like twitter will use the facebook system (OpenGraph) if it doesn't detect twitter specific tags.

A couple more thoughts:

  • this changes should probably affect not only the templates for the lessons (including instructor training) but also the main sites (e.g. software-carpentry.org)
  • I think the main site has recently implemented this, but I also think that the image used (the logo) is on transparent background which doesn't look good on twitter dark background for instance.

@ChristinaLK
Copy link
Contributor

Thanks @fmichonneau!

@raynamharris
Copy link
Contributor Author

Thanks @fmichonneau! Yes, the old SWC sites used to have the logo on them, so that would appear on facebook and such.

@ErinBecker
Copy link
Contributor

I think this is a good idea. I don't know anything about Facebook, however. Could someone put together a PR to implement this?

@weaverbel
Copy link
Contributor

I think this is done via the excerpt text in the page header @ErinBecker - Jonah and I added excerpt text to all SWC pages so that real text rather than boilerplate text would appear in Twitter grabs.

@karenword karenword added the bug-bbq Good for Bug BBQ label Apr 12, 2018
@brownsarahm
Copy link
Contributor

This has been determined to be an issue for styles in #1246 so we'll get those updates when the styles PR is merged and the updates propagate. I'll close this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-bbq Good for Bug BBQ pr-requested
Projects
None yet
Development

No branches or pull requests

7 participants