Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap and Co-Maintainership #236

Open
knatsakis opened this issue Aug 28, 2023 · 3 comments
Open

Roadmap and Co-Maintainership #236

knatsakis opened this issue Aug 28, 2023 · 3 comments

Comments

@knatsakis
Copy link
Contributor

Hi @carnager 👋🏻 ,

There seem to be a lot of open issues and PRs that haven't been attended to for a long a time. Is this project still maintained?

Would you be interested in adding a co-maintainer?

Regards!

@carnager
Copy link
Owner

carnager commented Feb 13, 2024

Yes, I agree, this needs some manpower that looks through PRs and Issues. So yeah, I am open for this. @moviuro has also been very active with supporting the project.

@carnager
Copy link
Owner

carnager commented Feb 13, 2024

There are a few things I would like to see for rofi-pass:

  • something to make parsing the password entries more reliable. (minimal yaml parser?)
  • maybe change the way autotype works. Right now it's a huge line which has to be manually parsed. While this is easy to type, it's quite messy to parse. Possible solution could be yaml lists. Changing to something like toml is (sadly) not an option, since this would break compatibility with other similar tools that adopted rofi-pass syntax. autotype itself is only used in rofi-pass tho, so changing this wouldn't matter much, as long as we stick to yaml syntax.
  • Simplify code and UI. Hotkeys are nice to have, but are not portable across similar tools like fzf, fuzzel, etc. Rofi is the best of its kind, but using it in wayland is a bit messy and users might want to use their own stdin/stdout tool as a UI frontend. The obvious solution would be to get rid of hotkeys and use submenus instead. While this might feel more cumbersome at first, it's an opportunity to clean this thing up and get rid of overkill functions. The added freedom to use whatever tool you want is worh it, I think. (e.g. use it in a terminal)
  • fix that mess of a config file, which is basically it's own bash script. It's ugly and functions simply don't belong into a config file. Also rofi-pass uses source to include it, which is dangerous and a total no-go. There are solutions like toml and tomlq, which could be used, but are much heavier. In the end one has to be honest here: There is no nice solution for a config file in bash scripts. Which brings me to my last bulletpoint:
  • Controversial, but maybe nice to have: Rewrite in a proper language. There is a lot of string parsing done in rofi-pass and many of the issues reported are about problems resulting from this. A proper language and a proper yaml parser would solve all these issues.

@carnager carnager pinned this issue Feb 13, 2024
@carnager carnager changed the title Would you consider adding a co-maintainer? Roadmap and Co-Maintainership Feb 13, 2024
@Seme4eg
Copy link

Seme4eg commented Jul 17, 2024

Hi! Maybe you can mention my fork somewhere at the end of your readme? I didn't make a PR because preserving backwards-compat would make the codebase much messier. I've been daily driving my fork for almost half a year now and works good. The 'mess of a config file' you mentioned is kinda resolved in my fork tho i dropped X support, which might be turning point for many.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants