feat: Add support for JDK 21 (#830)

carlspring · Aug 28, 2024 · da057ec · da057ec
1 parent 2873074
commit da057ec
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 9 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -54,7 +54,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ ubuntu-latest, windows-latest, macos-latest ]
-        java: [ 11, 17 ]
+        java: [ 11, 17, 21 ]
         #os: [ ubuntu-latest ]
         #java: [ 11 ]
     steps:
@@ -84,7 +84,7 @@ jobs:
             notifications
             jdks
           build-scan-publish: true
-          build-scan-terms-of-use-url: "https://gradle.com/help/legal-terms-of-use"
+          build-scan-terms-of-use-url: "https://gradle.com/terms-of-service"
           build-scan-terms-of-use-agree: "yes"
 
 
@@ -136,7 +136,7 @@ jobs:
 
       - name: Publish code analysis to Sonarcloud
         # [WARNING] The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
-        if: ${{ matrix.os == 'ubuntu-latest' && matrix.java == '17' }}
+        if: ${{ matrix.os == 'ubuntu-latest' && matrix.java == '21' }}
         env:
           GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
           S3FS_PUBLISH_SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

diff --git a/README.md b/README.md
@@ -33,7 +33,14 @@ This project provides a complete API implementation, for managing files and fold
 
 ## Compatibility
 
-We support JDK 8, 11 and 17.
+We aim to support only the latest LTS versions. At the moment this includes:
+
+* JDK 8
+* JDK 11
+* JDK 17
+* JDK 21
+
+Please note that although we support JDK 8 we have plans to drop it in one of our next **major** release (most likely `v2.0.0`).
 
 ## Documentation
 

diff --git a/src/main/java/org/carlspring/cloud/storage/s3fs/attribute/S3BasicFileAttributeView.java b/src/main/java/org/carlspring/cloud/storage/s3fs/attribute/S3BasicFileAttributeView.java
@@ -1,6 +1,8 @@
 package org.carlspring.cloud.storage.s3fs.attribute;
 
 import org.carlspring.cloud.storage.s3fs.S3Path;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.IOException;
 import java.nio.file.attribute.BasicFileAttributeView;
@@ -11,6 +13,7 @@ public class S3BasicFileAttributeView
         implements BasicFileAttributeView
 {
 
+    private static final Logger log = LoggerFactory.getLogger(S3BasicFileAttributeView.class);
     private S3Path s3Path;
 
 
@@ -37,7 +40,8 @@ public void setTimes(FileTime lastModifiedTime,
                          FileTime lastAccessTime,
                          FileTime createTime)
     {
-        // TODO: Not implemented
+        // TODO: Implement
+        log.debug(getClass() + "#setTimes() is not supported yet.");
     }
 
 }
diff --git a/src/main/java/org/carlspring/cloud/storage/s3fs/attribute/S3PosixFileAttributeView.java b/src/main/java/org/carlspring/cloud/storage/s3fs/attribute/S3PosixFileAttributeView.java
@@ -1,6 +1,8 @@
 package org.carlspring.cloud.storage.s3fs.attribute;
 
 import org.carlspring.cloud.storage.s3fs.S3Path;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.IOException;
 import java.nio.file.attribute.*;
@@ -11,6 +13,7 @@ public class S3PosixFileAttributeView
         implements PosixFileAttributeView
 {
 
+    private static final Logger log = LoggerFactory.getLogger(S3PosixFileAttributeView.class);
     private S3Path s3Path;
 
     private PosixFileAttributes posixFileAttributes;
@@ -44,25 +47,29 @@ public UserPrincipal getOwner()
     @Override
     public void setOwner(UserPrincipal owner)
     {
-        throw new UnsupportedOperationException();
+        // TODO: Implement
+        log.debug(getClass() + "#setOwner() is not supported yet.");
     }
 
     @Override
     public void setPermissions(Set<PosixFilePermission> perms)
     {
-        throw new UnsupportedOperationException();
+        // TODO: Implement
+        log.debug(getClass() + "#setPermissions() is not supported yet.");
     }
 
     @Override
     public void setGroup(GroupPrincipal group)
     {
-        throw new UnsupportedOperationException();
+        // TODO: Implement
+        log.debug(getClass() + "#setGroup() is not supported yet.");
     }
 
     @Override
     public void setTimes(FileTime lastModifiedTime, FileTime lastAccessTime, FileTime createTime)
     {
-        // TODO: Not implemented
+        // TODO: Implement
+        log.debug(getClass() + "#setTimes() is not supported yet.");
     }
 
     public PosixFileAttributes read()