[VF] updates includes addressing Ukraine labels

Closes twitter#1489
Closes twitter#1524
Closes twitter#1659
Closes twitter#1520

Author: twitter-team

visibilitylib/src/main/resources/config/com/twitter/visibility/decider.yml

@@ -494,6 +494,9 @@ visibility_library_enable_trends_representative_tweet_safety_level:
 visibility_library_enable_trusted_friends_user_list_safety_level:
   default_availability: 10000
 
+visibility_library_enable_twitter_delegate_user_list_safety_level:
+  default_availability: 10000
+
 visibility_library_enable_tweet_detail_safety_level:
   default_availability: 10000
 
@@ -758,7 +761,7 @@ visibility_library_enable_short_circuiting_from_blender_visibility_library:
 visibility_library_enable_short_circuiting_from_search_visibility_library:
   default_availability: 0
 
-visibility_library_enable_nsfw_text_topics_drop_rule:
+visibility_library_enable_nsfw_text_high_precision_drop_rule:
   default_availability: 10000
 
 visibility_library_enable_spammy_tweet_rule_verdict_logging:

visibilitylib/src/main/scala/com/twitter/visibility/configapi/configs/DeciderKey.scala

@@ -535,6 +535,9 @@ private[visibility] object DeciderKey extends DeciderKeyEnum {
   val EnableTrustedFriendsUserListSafetyLevel: Value = Value(
     "visibility_library_enable_trusted_friends_user_list_safety_level"
   )
+  val EnableTwitterDelegateUserListSafetyLevel: Value = Value(
+    "visibility_library_enable_twitter_delegate_user_list_safety_level"
+  )
   val EnableTweetDetailSafetyLevel: Value = Value(
     "visibility_library_enable_tweet_detail_safety_level"
   )
@@ -869,8 +872,8 @@ private[visibility] object DeciderKey extends DeciderKeyEnum {
     "visibility_library_enable_short_circuiting_from_search_visibility_library"
   )
 
-  val EnableNsfwTextTopicsDropRule: Value = Value(
-    "visibility_library_enable_nsfw_text_topics_drop_rule"
+  val EnableNsfwTextHighPrecisionDropRule: Value = Value(
+    "visibility_library_enable_nsfw_text_high_precision_drop_rule"
   )
 
   val EnableSpammyTweetRuleVerdictLogging: Value = Value(

visibilitylib/src/main/scala/com/twitter/visibility/configapi/configs/VisibilityDeciders.scala

@@ -198,6 +198,7 @@ private[visibility] object VisibilityDeciders {
     TopicRecommendations -> DeciderKey.EnableTopicRecommendationsSafetyLevel,
     TrendsRepresentativeTweet -> DeciderKey.EnableTrendsRepresentativeTweetSafetyLevel,
     TrustedFriendsUserList -> DeciderKey.EnableTrustedFriendsUserListSafetyLevel,
+    TwitterDelegateUserList -> DeciderKey.EnableTwitterDelegateUserListSafetyLevel,
     TweetDetail -> DeciderKey.EnableTweetDetailSafetyLevel,
     TweetDetailNonToo -> DeciderKey.EnableTweetDetailNonTooSafetyLevel,
     TweetEngagers -> DeciderKey.EnableTweetEngagersSafetyLevel,
@@ -287,7 +288,7 @@ private[visibility] object VisibilityDeciders {
     RuleParams.EnableDropAllTrustedFriendsTweetsRuleParam -> DeciderKey.EnableDropAllTrustedFriendsTweetsRule,
     RuleParams.EnableDropTrustedFriendsTweetContentRuleParam -> DeciderKey.EnableDropTrustedFriendsTweetContentRule,
     RuleParams.EnableDropAllCollabInvitationTweetsRuleParam -> DeciderKey.EnableDropCollabInvitationTweetsRule,
-    RuleParams.EnableNsfwTextTopicsDropRuleParam -> DeciderKey.EnableNsfwTextTopicsDropRule,
+    RuleParams.EnableNsfwTextHighPrecisionDropRuleParam -> DeciderKey.EnableNsfwTextHighPrecisionDropRule,
     RuleParams.EnableLikelyIvsUserLabelDropRule -> DeciderKey.EnableLikelyIvsUserLabelDropRule,
     RuleParams.EnableCardUriRootDomainCardDenylistRule -> DeciderKey.EnableCardUriRootDomainDenylistRule,
     RuleParams.EnableCommunityNonMemberPollCardRule -> DeciderKey.EnableCommunityNonMemberPollCardRule,

visibilitylib/src/main/scala/com/twitter/visibility/configapi/params/RuleParams.scala

@@ -85,7 +85,7 @@ private[visibility] object RuleParams {
 
   object EnableDropAllCollabInvitationTweetsRuleParam extends RuleParam(false)
 
-  object EnableNsfwTextTopicsDropRuleParam extends RuleParam(false)
+  object EnableNsfwTextHighPrecisionDropRuleParam extends RuleParam(false)
 
   object EnableLikelyIvsUserLabelDropRule extends RuleParam(false)
 

visibilitylib/src/main/scala/com/twitter/visibility/configapi/params/SafetyLevelParams.scala

@@ -186,6 +186,7 @@ private[visibility] object SafetyLevelParams {
   object EnableTopicRecommendationsSafetyLevelParam extends SafetyLevelParam(false)
   object EnableTrendsRepresentativeTweetSafetyLevelParam extends SafetyLevelParam(false)
   object EnableTrustedFriendsUserListSafetyLevelParam extends SafetyLevelParam(false)
+  object EnableTwitterDelegateUserListSafetyLevelParam extends SafetyLevelParam(false)
   object EnableTweetDetailSafetyLevelParam extends SafetyLevelParam(false)
   object EnableTweetDetailNonTooSafetyLevelParam extends SafetyLevelParam(false)
   object EnableTweetDetailWithInjectionsHydrationSafetyLevelParam extends SafetyLevelParam(false)

visibilitylib/src/main/scala/com/twitter/visibility/engine/VisibilityRuleEngine.scala

@@ -143,7 +143,7 @@ class VisibilityRuleEngine private[VisibilityRuleEngine] (
               builder.withRuleResult(rule, RuleResult(builder.verdict, ShortCircuited))
             } else {
 
-              if (rule.fallbackActionBuilder.nonEmpty) {
+              if (failedFeatureDependencies.nonEmpty && rule.fallbackActionBuilder.nonEmpty) {
                 metricsRecorder.recordRuleFallbackAction(rule.name)
               }
 

visibilitylib/src/main/scala/com/twitter/visibility/models/SafetyLevel.scala

@@ -194,6 +194,7 @@ object SafetyLevel {
     ThriftSafetyLevel.TopicsLandingPageTopicRecommendations -> TopicsLandingPageTopicRecommendations,
     ThriftSafetyLevel.TrendsRepresentativeTweet -> TrendsRepresentativeTweet,
     ThriftSafetyLevel.TrustedFriendsUserList -> TrustedFriendsUserList,
+    ThriftSafetyLevel.TwitterDelegateUserList -> TwitterDelegateUserList,
     ThriftSafetyLevel.GryphonDecksAndColumns -> GryphonDecksAndColumns,
     ThriftSafetyLevel.TweetDetail -> TweetDetail,
     ThriftSafetyLevel.TweetDetailNonToo -> TweetDetailNonToo,
@@ -772,6 +773,9 @@ object SafetyLevel {
   case object TrustedFriendsUserList extends SafetyLevel {
     override val enabledParam: SafetyLevelParam = EnableTrustedFriendsUserListSafetyLevelParam
   }
+  case object TwitterDelegateUserList extends SafetyLevel {
+    override val enabledParam: SafetyLevelParam = EnableTwitterDelegateUserListSafetyLevelParam
+  }
   case object TweetDetail extends SafetyLevel {
     override val enabledParam: SafetyLevelParam = EnableTweetDetailSafetyLevelParam
   }

visibilitylib/src/main/scala/com/twitter/visibility/models/SafetyLevelGroup.scala

@@ -379,13 +379,6 @@ object SafetyLevelGroup {
     )
   }
 
-  case object ProfileMixer extends SafetyLevelGroup {
-    override val levels: Set[SafetyLevel] = Set(
-      ProfileMixerMedia,
-      ProfileMixerFavorites,
-    )
-  }
-
   case object Reactions extends SafetyLevelGroup {
     override val levels: Set[SafetyLevel] = Set(
       SignalsReactions,
@@ -516,6 +509,10 @@ object SafetyLevelGroup {
       SafetyLevel.TimelineProfile,
       TimelineProfileAll,
       TimelineProfileSpaces,
+      TimelineMedia,
+      ProfileMixerMedia,
+      TimelineFavorites,
+      ProfileMixerFavorites
     )
   }
 

visibilitylib/src/main/scala/com/twitter/visibility/models/SpaceSafetyLabelType.scala

@@ -36,8 +36,8 @@ object SpaceSafetyLabelType extends SafetyLabelType {
     s.SpaceSafetyLabelType.HatefulHighRecall -> HatefulHighRecall,
     s.SpaceSafetyLabelType.ViolenceHighRecall -> ViolenceHighRecall,
     s.SpaceSafetyLabelType.HighToxicityModelScore -> HighToxicityModelScore,
-    s.SpaceSafetyLabelType.UkraineCrisisTopic -> UkraineCrisisTopic,
-    s.SpaceSafetyLabelType.DoNotPublicPublish -> DoNotPublicPublish,
+    s.SpaceSafetyLabelType.DeprecatedSpaceSafetyLabel14 -> Deprecated,
+    s.SpaceSafetyLabelType.DeprecatedSpaceSafetyLabel15 -> Deprecated,
     s.SpaceSafetyLabelType.Reserved16 -> Deprecated,
     s.SpaceSafetyLabelType.Reserved17 -> Deprecated,
     s.SpaceSafetyLabelType.Reserved18 -> Deprecated,
@@ -69,10 +69,6 @@ object SpaceSafetyLabelType extends SafetyLabelType {
   case object ViolenceHighRecall extends SpaceSafetyLabelType
   case object HighToxicityModelScore extends SpaceSafetyLabelType
 
-  case object UkraineCrisisTopic extends SpaceSafetyLabelType
-
-  case object DoNotPublicPublish extends SpaceSafetyLabelType
-
   case object Deprecated extends SpaceSafetyLabelType
   case object Unknown extends SpaceSafetyLabelType
 

visibilitylib/src/main/scala/com/twitter/visibility/rules/FreedomOfSpeechNotReach.scala

@@ -3,6 +3,7 @@ package com.twitter.visibility.rules
 import com.twitter.spam.rtf.thriftscala.SafetyResultReason
 import com.twitter.util.Memoize
 import com.twitter.visibility.common.actions.AppealableReason
+import com.twitter.visibility.common.actions.AvoidReason.MightNotBeSuitableForAds
 import com.twitter.visibility.common.actions.LimitedEngagementReason
 import com.twitter.visibility.common.actions.SoftInterventionDisplayType
 import com.twitter.visibility.common.actions.SoftInterventionReason
@@ -440,36 +441,6 @@ object FreedomOfSpeechNotReachActions {
     }
   }
 
-  case class ConversationSectionAbusiveQualityAction(
-    violationLevel: ViolationLevel = DefaultViolationLevel)
-      extends FreedomOfSpeechNotReachActionBuilder[ConversationSectionAbusiveQuality.type] {
-
-    override def actionType: Class[_] = ConversationSectionAbusiveQuality.getClass
-
-    override val actionSeverity = 5
-    private def toRuleResult: Reason => RuleResult = Memoize { r =>
-      RuleResult(ConversationSectionAbusiveQuality, Evaluated)
-    }
-
-    def build(evaluationContext: EvaluationContext, featureMap: Map[Feature[_], _]): RuleResult = {
-      val appealableReason =
-        FreedomOfSpeechNotReach.extractTweetSafetyLabel(featureMap).map(_.labelType) match {
-          case Some(label) =>
-            FreedomOfSpeechNotReach.eligibleTweetSafetyLabelTypesToAppealableReason(
-              label,
-              violationLevel)
-          case _ =>
-            AppealableReason.Unspecified(violationLevel.level)
-        }
-
-      toRuleResult(Reason.fromAppealableReason(appealableReason))
-    }
-
-    override def withViolationLevel(violationLevel: ViolationLevel) = {
-      copy(violationLevel = violationLevel)
-    }
-  }
-
   case class SoftInterventionAvoidAction(violationLevel: ViolationLevel = DefaultViolationLevel)
       extends FreedomOfSpeechNotReachActionBuilder[TweetInterstitial] {
 
@@ -662,6 +633,9 @@ object FreedomOfSpeechNotReachRules {
 
     override def enabled: Seq[RuleParam[Boolean]] =
       Seq(EnableFosnrRuleParam, FosnrRulesEnabledParam)
+
+    override val fallbackActionBuilder: Option[ActionBuilder[_ <: Action]] = Some(
+      new ConstantActionBuilder(Avoid(Some(MightNotBeSuitableForAds))))
   }
 
   case class ViewerIsNonFollowerNonAuthorAndTweetHasViolationOfLevel(
@@ -678,6 +652,9 @@ object FreedomOfSpeechNotReachRules {
 
     override def enabled: Seq[RuleParam[Boolean]] =
       Seq(EnableFosnrRuleParam, FosnrRulesEnabledParam)
+
+    override val fallbackActionBuilder: Option[ActionBuilder[_ <: Action]] = Some(
+      new ConstantActionBuilder(Avoid(Some(MightNotBeSuitableForAds))))
   }
 
   case class ViewerIsNonAuthorAndTweetHasViolationOfLevel(
@@ -692,6 +669,9 @@ object FreedomOfSpeechNotReachRules {
 
     override def enabled: Seq[RuleParam[Boolean]] =
       Seq(EnableFosnrRuleParam, FosnrRulesEnabledParam)
+
+    override val fallbackActionBuilder: Option[ActionBuilder[_ <: Action]] = Some(
+      new ConstantActionBuilder(Avoid(Some(MightNotBeSuitableForAds))))
   }
 
   case object TweetHasViolationOfAnyLevelFallbackDropRule

visibilitylib/src/main/scala/com/twitter/visibility/rules/RuleBase.scala

@@ -188,6 +188,7 @@ object RuleBase {
     TopicRecommendations -> TopicRecommendationsPolicy,
     TrendsRepresentativeTweet -> TrendsRepresentativeTweetPolicy,
     TrustedFriendsUserList -> TrustedFriendsUserListPolicy,
+    TwitterDelegateUserList -> TwitterDelegateUserListPolicy,
     TweetDetail -> TweetDetailPolicy,
     TweetDetailNonToo -> TweetDetailNonTooPolicy,
     TweetDetailWithInjectionsHydration -> TweetDetailWithInjectionsHydrationPolicy,

visibilitylib/src/main/scala/com/twitter/visibility/rules/TweetLabelRules.scala

@@ -144,6 +144,9 @@ object NsfwCardImageAvoidAllUsersTweetLabelRule
       action = Avoid(Some(AvoidReason.ContainsNsfwMedia)),
     ) {
   override def enabled: Seq[RuleParam[Boolean]] = Seq(EnableAvoidNsfwRulesParam)
+
+  override val fallbackActionBuilder: Option[ActionBuilder[_ <: Action]] = Some(
+    new ConstantActionBuilder(Avoid(Some(MightNotBeSuitableForAds))))
 }
 
 object NsfwCardImageAvoidAdPlacementAllUsersTweetLabelRule
@@ -247,6 +250,9 @@ object GoreAndViolenceHighPrecisionAvoidAllUsersTweetLabelRule
       TweetSafetyLabelType.GoreAndViolenceHighPrecision
     ) {
   override def enabled: Seq[RuleParam[Boolean]] = Seq(EnableAvoidNsfwRulesParam)
+
+  override val fallbackActionBuilder: Option[ActionBuilder[_ <: Action]] = Some(
+    new ConstantActionBuilder(Avoid(Some(MightNotBeSuitableForAds))))
 }
 
 object GoreAndViolenceHighPrecisionAllUsersTweetLabelRule
@@ -266,6 +272,9 @@ object NsfwReportedHeuristicsAvoidAllUsersTweetLabelRule
       TweetSafetyLabelType.NsfwReportedHeuristics
     ) {
   override def enabled: Seq[RuleParam[Boolean]] = Seq(EnableAvoidNsfwRulesParam)
+
+  override val fallbackActionBuilder: Option[ActionBuilder[_ <: Action]] = Some(
+    new ConstantActionBuilder(Avoid(Some(MightNotBeSuitableForAds))))
 }
 
 object NsfwReportedHeuristicsAvoidAdPlacementAllUsersTweetLabelRule
@@ -274,6 +283,9 @@ object NsfwReportedHeuristicsAvoidAdPlacementAllUsersTweetLabelRule
       TweetSafetyLabelType.NsfwReportedHeuristics
     ) {
   override def enabled: Seq[RuleParam[Boolean]] = Seq(EnableAvoidNsfwRulesParam)
+
+  override val fallbackActionBuilder: Option[ActionBuilder[_ <: Action]] = Some(
+    new ConstantActionBuilder(Avoid(Some(MightNotBeSuitableForAds))))
 }
 
 object NsfwReportedHeuristicsAllUsersTweetLabelRule
@@ -294,6 +306,9 @@ object GoreAndViolenceReportedHeuristicsAvoidAllUsersTweetLabelRule
       TweetSafetyLabelType.GoreAndViolenceReportedHeuristics
     ) {
   override def enabled: Seq[RuleParam[Boolean]] = Seq(EnableAvoidNsfwRulesParam)
+
+  override val fallbackActionBuilder: Option[ActionBuilder[_ <: Action]] = Some(
+    new ConstantActionBuilder(Avoid(Some(MightNotBeSuitableForAds))))
 }
 
 object GoreAndViolenceReportedHeuristicsAvoidAdPlacementAllUsersTweetLabelRule
@@ -302,6 +317,9 @@ object GoreAndViolenceReportedHeuristicsAvoidAdPlacementAllUsersTweetLabelRule
       TweetSafetyLabelType.GoreAndViolenceReportedHeuristics
     ) {
   override def enabled: Seq[RuleParam[Boolean]] = Seq(EnableAvoidNsfwRulesParam)
+
+  override val fallbackActionBuilder: Option[ActionBuilder[_ <: Action]] = Some(
+    new ConstantActionBuilder(Avoid(Some(MightNotBeSuitableForAds))))
 }
 
 object GoreAndViolenceHighPrecisionAllUsersTweetLabelDropRule
@@ -791,7 +809,7 @@ object SkipTweetDetailLimitedEngagementTweetLabelRule
 object DynamicProductAdDropTweetLabelRule
     extends TweetHasLabelRule(Drop(Unspecified), TweetSafetyLabelType.DynamicProductAd)
 
-object NsfwTextTweetLabelTopicsDropRule
+object NsfwTextHighPrecisionTweetLabelDropRule
     extends RuleWithConstantAction(
       Drop(Reason.Nsfw),
       And(
@@ -803,7 +821,7 @@ object NsfwTextTweetLabelTopicsDropRule
       )
     )
     with DoesLogVerdict {
-  override def enabled: Seq[RuleParam[Boolean]] = Seq(EnableNsfwTextTopicsDropRuleParam)
+  override def enabled: Seq[RuleParam[Boolean]] = Seq(EnableNsfwTextHighPrecisionDropRuleParam)
   override def actionSourceBuilder: Option[RuleActionSourceBuilder] = Some(
     TweetSafetyLabelSourceBuilder(TweetSafetyLabelType.NsfwTextHighPrecision))
 }
@@ -832,7 +850,10 @@ object DoNotAmplifyTweetLabelAvoidRule
     extends TweetHasLabelRule(
       Avoid(),
       TweetSafetyLabelType.DoNotAmplify
-    )
+    ) {
+  override val fallbackActionBuilder: Option[ActionBuilder[_ <: Action]] = Some(
+    new ConstantActionBuilder(Avoid(Some(MightNotBeSuitableForAds))))
+}
 
 object NsfaHighPrecisionTweetLabelAvoidRule
     extends TweetHasLabelRule(