Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted dates are converted to string on parse #40

Open
fmluizao opened this issue Jul 24, 2015 · 0 comments
Open

Converted dates are converted to string on parse #40

fmluizao opened this issue Jul 24, 2015 · 0 comments

Comments

@fmluizao
Copy link

I18n::Alchemy::DateParser.parse("07/07/2015")
=> "2015-07-07"

From I18n::Alchemy::DateParser#parse, we have:

build_object(parsed_date).to_s

Why we need to convert the date back to string? I think it's better just return the Date object. ActiveRecord will not complain, and the parser would be more generic.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant