Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute integration to Home Assistant #93

Open
3 tasks done
balloob opened this issue Feb 4, 2024 · 3 comments
Open
3 tasks done

Contribute integration to Home Assistant #93

balloob opened this issue Feb 4, 2024 · 3 comments

Comments

@balloob
Copy link

balloob commented Feb 4, 2024

Checklist

  • I have filled out the template to the best of my ability.
  • This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
  • This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.

I would love for Home Assistant users to be able to access the high quality voices from Eleven Labs in Home Assistant without having to learn how to install a custom integration.

Describe the solution you'd like

Contribute the integration to Home Assistant core.

Describe alternatives you've considered

Hacs

Additional context

Tag me when you make the PR and mention this issue and I’ll prioritize review.

@carleeno
Copy link
Owner

carleeno commented Feb 6, 2024

Thanks for the request! I'd love to add this as an official integration, however currently I'm traveling full time and unable to dedicate time for developing this much further than keeping the lights on.
There is still a lot of missing test coverage which I think will block this becoming part of core for a while.

If you can suggest anybody who'd like to take this over I'd likely be willing to give the keys over to someone with more time for this, or I could at least still support in general maintenance etc. Otherwise I expect at least another couple of months before I settle down and start using HA again (after getting a new home) and would have time and practicality to work on this again.

@sorgfresser
Copy link

Hi! I'm not sure whether it would be easy to contribute this to the core repo as core requires any communication with an external service to be done through a pypi-package, thus I'm pretty sure the elevenlabs.py would not go through.
I have rewritten part of the integration from scratch using the elevenlabs python sdk and created a PR for this (home-assistant/core#115645)
It is not feature complete, so maybe we can take your config_flow.py and add the required features using the elevenlabs python sdk? I did not want to copy your code without asking though...

@carleeno
Copy link
Owner

Hi! I'm not sure whether it would be easy to contribute this to the core repo as core requires any communication with an external service to be done through a pypi-package, thus I'm pretty sure the elevenlabs.py would not go through. I have rewritten part of the integration from scratch using the elevenlabs python sdk and created a PR for this (home-assistant/core#115645) It is not feature complete, so maybe we can take your config_flow.py and add the required features using the elevenlabs python sdk? I did not want to copy your code without asking though...

@sorgfresser thanks for asking, but it's no problem at all, copy anything that's useful. Maybe when I am able to use HA again I'll be able to start contributing to your official integration rather than this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants