You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reduce boilerplate and have cleaner code. This is also a first step into achieving better memory profile for hydra-node #1618
What
Remove ServerOutput type and add/create constructors in StateChanged (Most ServerOutputs directly map to a StateChanged event, Some additional events need to be created to server outputs like PeerConnected et al)
Instead of cause ClientEffect, the HeadLogic would emit events with newState.
Example:
As I was reviewing the PR for this, I wondered.. why? The change described here seems to be a pure refactoring (no change in semantics) and I'm personally not convinced that this is exactly what we need.
Instead, we should be aiming to solve the actual problem #1618 and then do the refactoring based on the new semantics.
Why
Reduce boilerplate and have cleaner code. This is also a first step into achieving better memory profile for hydra-node #1618
What
ServerOutput
type and add/create constructors inStateChanged
(Most ServerOutputs directly map to a StateChanged event, Some additional events need to be created to server outputs like PeerConnected et al)cause ClientEffect
, theHeadLogic
would emit events withnewState
.Example:
hydra/hydra-node/src/Hydra/HeadLogic.hs
Lines 599 to 600 in f770319
would become
The text was updated successfully, but these errors were encountered: