Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction signing example code in java #275

Open
Kartiiyer12 opened this issue Feb 7, 2025 · 4 comments
Open

Add transaction signing example code in java #275

Kartiiyer12 opened this issue Feb 7, 2025 · 4 comments

Comments

@Kartiiyer12
Copy link
Collaborator

Why

To make the repo have e2e testing and cover all the test cases, transaction signing should also be included.

What

We need to have a java based transaction signing code example similar to what we have in ts - https://github.com/cardano-foundation/cardano-rosetta/blob/master/examples/postman/sign-transaction-server.js

@Kammerlo
Copy link
Member

Kammerlo commented Feb 7, 2025

Hey thanks for raising this.
Question, do you want to have an additional endpoint to sign transactions (like in the example you shared) or do you just want en e2e transaction signing written in java?

@Kartiiyer12
Copy link
Collaborator Author

The way it works currently is we can send a pre-request from the /combine endpoint where the the transaction is signed on another server endpoint(probably an internal cold server where keys exists) and the response from the /combine request is the signed transaction which can be submitted. So I think an separate api end point not within the rosetta api list.

What do you mean by e2e transaction signing? How would that integrate with rosetta API calls?

@Kammerlo
Copy link
Member

Kammerlo commented Feb 8, 2025

We could add an additional endpoint e.g. /construction/sign with the same functionality. Then users are free to decide how to use it. In offline_mode in a cold environment or where ever they need it.

@Kartiiyer12
Copy link
Collaborator Author

Yeah, that would b e good custom addition to the endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants