New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨ID-115 Informational: Incorrect Type #205

Open

1 task done

SamGrantDev opened this issue Jan 21, 2025 · 0 comments

Open

1 task done

🚨ID-115 Informational: Incorrect Type #205

SamGrantDev opened this issue Jan 21, 2025 · 0 comments

SamGrantDev commented Jan 21, 2025

Is there an existing issue for this?

I have searched the existing issues

Task description 🔨🔧

Description

The amount field of FungibleTokenPacketData is defined as a ByteArray instead of an integer as per ICS-20. This discrepancy:

Results in costly bytearray-to-integer conversions.
Risks decoding issues due to differing encoding schemes.

Recommendation

Update the amount field to conform to ICS-20 by making it an integer.

Anything else?

No response

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment